1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/files
epriestley 943c62d1e9 Add missing expected keys and uniqueness
Summary:
Ref T1191.

  - Adds definitions for missing keys and keys with wrong uniqueness. Generally, I defined these before fixing the key query to actually pull all keys and support uniqueness.
  - Moves "key uniqueness" to note severity; this is fixable (probably?) and there are no remaining issues.
  - Moves "Missing Key" to note severity; missing keys are fixable and all remaining missing keys are really missing (either missing edge keys, or missing PHID keys):

{F210089}

  - Moves "Surplus Key" to note seveirty; surplus keys are fixable all remaining surplus keys are really surplus (duplicate key in Harbormaster, key on unused column in Worker):

{F210090}

Test Plan:
  - Vetted missing/surplus/unique messages.
  - 146 issues remaining.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10590
2014-10-01 07:53:50 -07:00
..
application Files - make file info page public 2014-08-20 13:18:21 -07:00
conduit file.upload set policy explicitly 2014-08-07 12:14:17 -07:00
config Remove @group annotations 2014-07-10 08:12:48 +10:00
controller Transactions - hide "mentioned in X" story if you can't see X 2014-09-16 12:12:35 -07:00
editor Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
engine Paste - fix caching mechanism for S3-stored files 2014-08-19 12:01:17 -07:00
engineselector Fix "are are" in explanatory text 2014-09-18 08:21:34 -07:00
exception Remove @group annotations 2014-07-10 08:12:48 +10:00
garbagecollector Complete modularization of the GC daemon 2014-01-15 10:02:31 -08:00
lipsum Made Changes to Mock and File generation after pushing some methods to superclass 2013-05-06 13:32:01 -07:00
mail Rename PhabricatorApplication subclasses 2014-07-23 10:03:09 +10:00
management Add bin/files compact for sharing file data storage 2014-08-21 11:47:59 -07:00
markup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
phid Make file handles have "/Fxxx" as the URI 2014-08-21 12:21:10 -07:00
query Bind file thumbnail visibility to the visibility of the original files 2014-09-04 12:49:31 -07:00
storage Add missing expected keys and uniqueness 2014-10-01 07:53:50 -07:00
view Give files uploaded to objects a very restrictive view policy 2014-08-02 14:46:13 -07:00
PhabricatorImageTransformer.php Add a CanCDN flag to uploaded files 2014-08-07 18:56:20 -07:00