mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-25 21:19:21 +01:00
d436fecdab
Summary: Ref T10457. When tests fail, it currently takes several clicks to figure out //why// they failed. In this project, map rebuilds and `liberate` are fairly common failure conditions, but verifying that they were the root issue requires jumping into a build, then scrolling through a log. Instead, display details if they're available. Test Plan: Before: {F1135453} After: {F1135454} Reviewers: chad Reviewed By: chad Maniphest Tasks: T9951, T10457 Differential Revision: https://secure.phabricator.com/D15363
122 lines
3.2 KiB
PHP
122 lines
3.2 KiB
PHP
<?php
|
|
|
|
final class HarbormasterUnitMessageViewController
|
|
extends HarbormasterController {
|
|
|
|
public function handleRequest(AphrontRequest $request) {
|
|
$viewer = $this->getViewer();
|
|
|
|
$message_id = $request->getURIData('id');
|
|
|
|
$message = id(new HarbormasterBuildUnitMessage())->load($message_id);
|
|
if (!$message) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$build_target = id(new HarbormasterBuildTargetQuery())
|
|
->setViewer($viewer)
|
|
->withPHIDs(array($message->getBuildTargetPHID()))
|
|
->executeOne();
|
|
if (!$build_target) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$build = $build_target->getBuild();
|
|
$buildable = $build->getBuildable();
|
|
$buildable_id = $buildable->getID();
|
|
|
|
$id = $message->getID();
|
|
$display_name = $message->getUnitMessageDisplayName();
|
|
|
|
$status = $message->getResult();
|
|
$status_icon = HarbormasterUnitStatus::getUnitStatusIcon($status);
|
|
$status_color = HarbormasterUnitStatus::getUnitStatusColor($status);
|
|
$status_label = HarbormasterUnitStatus::getUnitStatusLabel($status);
|
|
|
|
$header = id(new PHUIHeaderView())
|
|
->setHeader($display_name)
|
|
->setStatus($status_icon, $status_color, $status_label);
|
|
|
|
$properties = $this->buildPropertyListView($message);
|
|
$actions = $this->buildActionView($message, $build);
|
|
|
|
$properties->setActionList($actions);
|
|
|
|
$unit = id(new PHUIObjectBoxView())
|
|
->setHeader($header)
|
|
->addPropertyList($properties);
|
|
|
|
$crumbs = $this->buildApplicationCrumbs();
|
|
$this->addBuildableCrumb($crumbs, $buildable);
|
|
|
|
$crumbs->addTextCrumb(
|
|
pht('Unit Tests'),
|
|
"/harbormaster/unit/{$buildable_id}/");
|
|
|
|
$crumbs->addTextCrumb(pht('Unit %d', $id));
|
|
|
|
$title = array(
|
|
$display_name,
|
|
$buildable->getMonogram(),
|
|
);
|
|
|
|
return $this->newPage()
|
|
->setTitle($title)
|
|
->setCrumbs($crumbs)
|
|
->appendChild($unit);
|
|
}
|
|
|
|
private function buildPropertyListView(
|
|
HarbormasterBuildUnitMessage $message) {
|
|
$request = $this->getRequest();
|
|
$viewer = $request->getUser();
|
|
|
|
$view = id(new PHUIPropertyListView())
|
|
->setUser($viewer);
|
|
|
|
$view->addProperty(
|
|
pht('Run At'),
|
|
phabricator_datetime($message->getDateCreated(), $viewer));
|
|
|
|
$details = $message->getUnitMessageDetails();
|
|
if (strlen($details)) {
|
|
// TODO: Use the log view here, once it gets cleaned up.
|
|
$details = phutil_tag(
|
|
'div',
|
|
array(
|
|
'class' => 'PhabricatorMonospaced',
|
|
'style' =>
|
|
'white-space: pre-wrap; '.
|
|
'color: #666666; '.
|
|
'overflow-x: auto;',
|
|
),
|
|
$details);
|
|
} else {
|
|
$details = phutil_tag('em', array(), pht('No details provided.'));
|
|
}
|
|
|
|
$view->addSectionHeader(
|
|
pht('Details'),
|
|
PHUIPropertyListView::ICON_TESTPLAN);
|
|
$view->addTextContent($details);
|
|
|
|
return $view;
|
|
}
|
|
|
|
private function buildActionView(
|
|
HarbormasterBuildUnitMessage $message,
|
|
HarbormasterBuild $build) {
|
|
$viewer = $this->getViewer();
|
|
|
|
$view = id(new PhabricatorActionListView())
|
|
->setUser($viewer);
|
|
|
|
$view->addAction(
|
|
id(new PhabricatorActionView())
|
|
->setName(pht('View Build'))
|
|
->setHref($build->getURI())
|
|
->setIcon('fa-wrench'));
|
|
|
|
return $view;
|
|
}
|
|
}
|