1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-03 18:38:27 +01:00
phorge-phorge/src/applications/owners
epriestley 53f8ad14fa Fix an issue in Owners where a transaction change could show too many effects
Summary:
Fixes T13324. Ref PHI1288. Currently, if you edit an Owners package that has some paths with no trailing slashes (like `README.md`) so their internal names and display names differ (`/README.md` display, vs `/README.md/` internal), the "Show Details" in the transaction log shows the path as re-normalized even if you didn't touch it.

Instead, be more careful about handling display paths vs internal paths.

(This code on the whole is significantly less clear than it probably could be, but this issue is so minor that I'm hesitant to start ripping things out.)

Test Plan:
  - In a package with some paths like `/src/` and some paths like `/src`:
  - Added new paths.
  - Removed paths.
  - Changed paths from `/src/` to `/src`.
  - Changed paths from `/src` to `/src/`.

In all cases, the "paths" list and the transaction record identically reflected the edit in the way I expected them to.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13324

Differential Revision: https://secure.phabricator.com/D20596
2019-06-20 16:08:31 -07:00
..
application Give Owners packages the "O" monogram 2016-05-13 17:18:15 -07:00
capability Give Owners real view and edit policies 2016-02-15 11:56:35 -08:00
conduit Formally deprecate owners.query Conduit API method 2016-04-20 09:04:45 -07:00
config Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
constants Support a wider range of "Audit" rules for Owners packages 2019-02-07 15:39:39 -08:00
controller Index and show Owners packages affected by Herald rules 2019-04-17 12:17:30 -07:00
customfield Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
editor Prepare owners package audit rules to become more flexible 2019-02-07 15:38:12 -08:00
engineextension Treat Owners paths like "/src/backend" and "/src/backend/" identically 2018-03-06 20:31:46 -08:00
lipsum Add an owners package generator for Lipsum 2017-02-27 09:11:04 -08:00
mail Build separate mail for each recipient, honoring recipient access levels 2015-06-03 18:59:31 -07:00
phid Add more mail stamps: tasks, subscribers, projects, spaces 2018-02-06 04:05:46 -08:00
query Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
remarkup Give Owners packages the "O" monogram 2016-05-13 17:18:15 -07:00
search Support Ferret engine in Owners 2017-09-07 13:23:46 -07:00
searchfield Flesh out Conduit parmeter types for maniphest.search 2015-12-14 04:24:01 -08:00
storage Fix an issue in Owners where a transaction change could show too many effects 2019-06-20 16:08:31 -07:00
typeahead Fix packages(project) to work properly and add it to "MailableFunctionDatasource" 2018-10-19 13:53:27 -07:00
xaction Fix an issue in Owners where a transaction change could show too many effects 2019-06-20 16:08:31 -07:00