1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-25 23:10:57 +01:00
phorge-phorge/src
epriestley f9192d07f2 Align web UI "Disable" and "Approve/Disapprove" flows with new "Can Disable Users" permission
Summary:
Depends on D19606. Ref T13189. See PHI642.

  - Disabling/enabling users no longer requires admin. Now, you just need "Can Disable Users".
  - Update the UI to appropriately show the action in black or grey depending on what clicking the button will do.
  - For "Approve/Disapprove", fix a couple bugs, then let them go through without respect for "Can Disable Users". This is conceptually a different action, even though it ultimately sets the "Disabled" flag.

Test Plan:
  - Disabled/enabled users from the web UI as various users, including a non-administrator with "Can Disable Users".
  - Hit permissions errors from the web UI as various users, including an administrator without "Can Disable Users".
  - Saw the "Disable/Enable" action activate properly based on whether clicking the button would actually work.
  - Disapproved a user without "Can Disable Users" permission, tried to re-disapprove a user.
  - Approved a user, tried to reapprove a user.

Reviewers: amckinley

Maniphest Tasks: T13189

Differential Revision: https://secure.phabricator.com/D19607
2018-08-27 08:09:42 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Remove the execution time limit (if any) before sinking HTTP responses 2018-07-30 10:56:05 -07:00
applications Align web UI "Disable" and "Approve/Disapprove" flows with new "Can Disable Users" permission 2018-08-27 08:09:42 -07:00
docs Allow mailers to be explicitly marked as inbound or outbound 2018-07-30 08:25:06 -07:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Add some missing aural button labels for accessibility 2018-08-17 11:00:29 -07:00
view Add more accessibility labels for screen readers 2018-08-17 13:31:51 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Add a "Can Disable Users" capability to the "People" application 2018-08-27 08:01:27 -07:00