1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-21 09:48:47 +02:00
phorge-phorge/src/infrastructure
epriestley f8cebdc418 Make Differential inline events actually trigger comment preview refreshes
Summary:
Earlier, I made some changes so that when you create or edit an inline, the comment at the bottom of the page updates (even though you didn't fiddle with the stacked actions inputs).

At the last second I broke them by spelling this wrong while cleaning things up, so they didn't actually work. Spell the property correctly ("showPreview", not "shouldPreview").

Also, we have some JS which rewrites "Not Visible" into "View", but it fires in an inconvenient way now and is flickery for me. Ideally this should get cleaned up slightly better eventualy, but at least make is stop doing so much flickery layout for now.

Test Plan:
  - Wrote no comment on a revision.
  - Added an inline.
  - Saw comment preview properly update immediately.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17229
2017-01-19 12:32:49 -08:00
..
cluster Fix two errors from the error logs 2016-11-26 07:50:57 -08:00
contentsource Redesign Config Application 2016-08-29 15:49:49 -07:00
customfield Simplify Auditors custom field in Differential 2016-12-16 10:09:30 -08:00
daemon Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
diff Make Differential inline events actually trigger comment preview refreshes 2017-01-19 12:32:49 -08:00
edges Log and continue when trying to destroy edges with no edge definition 2016-06-23 06:45:17 -07:00
env Normalize remote IP addresses when writing to logs, etc 2016-12-05 11:20:29 -08:00
events Modernize Hovercard implementation 2015-12-24 12:18:28 -08:00
graph In Maniphest, don't render the task graph drawing if we're only showing parents/children 2016-11-07 11:09:20 -08:00
internationalization Document calendar summary icons 2016-11-15 13:44:20 -08:00
javelin Extend from Phobject 2015-06-15 18:02:27 +10:00
lint/linter Linter fixes 2015-12-03 07:44:23 +11:00
log Extend from Phobject 2015-06-15 18:02:27 +10:00
management Modularize content sources 2016-03-26 11:59:45 -07:00
markup Prevent media from autoplaying when rendered as a feed story 2016-11-22 14:19:56 -08:00
query Make query engines "overheat" instead of stalling when filtering too many results 2016-10-20 09:31:37 -07:00
sms Various linter fixes 2015-08-11 22:36:55 +10:00
ssh Normalize remote IP addresses when writing to logs, etc 2016-12-05 11:20:29 -08:00
storage Fix flaky subscribers policy rule unit test 2016-12-11 12:27:57 -08:00
syntax Pass the new default syntax highlighting map to the remarkup engine 2016-05-05 02:51:19 -07:00
testing Make caches misses throw by default intead of inline-generating 2016-06-05 08:51:54 -07:00
time Make translation, timezone and pronoun into real settings 2016-06-02 06:29:47 -07:00
util Make cluster repositories more resistant to freezing 2016-04-25 11:37:31 -07:00
PhabricatorEditor.php Mark some strings for translation 2015-06-09 23:06:52 +10:00