1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
phorge-phorge/src/applications/maniphest/herald
epriestley fbfcc37531 Respect token limits for "Assign to" and custom datasource fields in Herald
Summary:
See PHI173. Currently, Herald has an "Assign to" action for tasks, and you can specify custom fields with datasource values (like users or projects) that have a limit (like 1 "Owner", or 12 "Jury Members").

Herald doesn't support these limits right now, so you can write `[ Assign to ][ X, Y, Z ]`. This just means "Assign to X", but make it more clear by actually enforcing the limit in the UI.

Test Plan:
  - Created a "projects" custom field with limit 1.
  - Tried to create actions that 'assign to' or 'set custom field to' more than one thing, got helpfully rebuffed by the UI.
  - Created an "add subscribers" action with more than one value.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18887
2018-01-22 11:54:12 -08:00
..
HeraldManiphestTaskAdapter.php Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
ManiphestTaskAssigneeHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
ManiphestTaskAssignHeraldAction.php Update Maniphest for modular transactions 2017-05-15 10:29:06 -07:00
ManiphestTaskAssignOtherHeraldAction.php Respect token limits for "Assign to" and custom datasource fields in Herald 2018-01-22 11:54:12 -08:00
ManiphestTaskAssignSelfHeraldAction.php Modularize Maniphest Herald "Assign Task" action 2015-08-03 14:33:25 -07:00
ManiphestTaskAuthorHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
ManiphestTaskDescriptionHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
ManiphestTaskHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
ManiphestTaskHeraldFieldGroup.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
ManiphestTaskPriorityHeraldAction.php Use keywords instead of ints to update task priority in ManiphestEditEngine 2017-06-14 14:43:03 -07:00
ManiphestTaskPriorityHeraldField.php Support "Select" custom fields in Herald rules 2015-07-16 14:12:54 -07:00
ManiphestTaskStatusHeraldAction.php Update Maniphest for modular transactions 2017-05-15 10:29:06 -07:00
ManiphestTaskStatusHeraldField.php Support "Select" custom fields in Herald rules 2015-07-16 14:12:54 -07:00
ManiphestTaskTitleHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00