mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-22 13:30:55 +01:00
b560014577
Summary:
Rebuilds the UI in Differential commenting. Specifically we look at the following design patterns:
**To the author:**
- The author of the diff should be able to easily identify what comments are done and not done.
- We keep undone comments yellow
- Clicking done turns comment block into 'unsubmitted state'
**To the reviewer:**
- Easier understanding of unsubmitted states
- All conversations to be yellow/important
**Todo**
- Not all color CSS states correct
- Unpulished checkbox support
Test Plan:
Test leaving comments, published and unpublished. Checking Done, unpublished and published. Check delete states.
From the Diff Author's perspective:
{F352094}
For a Diff commenter's perspective:
{F352095}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T1460, T7660, T7503
Differential Revision: https://secure.phabricator.com/D12171
17 lines
314 B
CSS
17 lines
314 B
CSS
/**
|
|
* @provides differential-revision-add-comment-css
|
|
*/
|
|
|
|
#inline-comment-preview {
|
|
margin-left: 62px;
|
|
width: 640px;
|
|
}
|
|
|
|
#inline-comment-preview .differential-inline-comment {
|
|
margin: 12px 0;
|
|
}
|
|
|
|
#inline-comment-preview
|
|
.differential-inline-comment + .differential-inline-comment {
|
|
margin: 0 0 12px 0;
|
|
}
|