1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/ponder
epriestley f1c75a6382 Allow construction of ApplicationSearch queries with GET
Summary:
Ref T3775 (discussion here). Ref T2625.

T3775 presents two problems:

  # Existing tools which linked to `/differential/active/epriestley/` (that is, put a username in the URL) can't generate search links now.
  # Humans can't edit the URL anymore, either.

I think (1) is an actual issue, and this fixes it. I think (2) is pretty fluff, and this doesn't really try to fix it, although it probably improves it.

The fix for (1) is:

  - Provide a helper to read a parameter containing either a list of user PHIDs or a list of usernames, so `/?users[]=PHID-USER-xyz` (from a tokenizer) and `/?users=alincoln,htaft` (from an external program) are equivalent inputs.
  - Rename all the form parameters to be more digestable (`authorPHIDs` -> `authors`). Almost all of them were in this form already anyway. This just gives us `?users=alincoln` instead of `userPHIDs=alincoln`.
  - Inside ApplicationSearch, if a request has no query associated with it but does have query parameters, build a query from the request instead of issuing the user's default query. Basically, this means that `/differential/` runs the default query, while `/differential/?users=x` runs a custom query.

Test Plan: {F56612}

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2625, T3775

Differential Revision: https://secure.phabricator.com/D6840
2013-08-29 11:52:29 -07:00
..
application Use PHUIRemarkupPreviewPanel in Ponder 2013-08-05 10:47:06 -07:00
constants Use PHUIRemarkupPreviewPanel in Ponder 2013-08-05 10:47:06 -07:00
controller Update Form Layouts 2013-08-26 11:53:11 -07:00
editor Restore mail to Ponder 2013-07-29 12:04:20 -07:00
mail Restore mail to Ponder 2013-07-29 12:04:20 -07:00
phid Use Application PHIDs for ANSW 2013-07-28 15:08:35 -07:00
query Allow construction of ApplicationSearch queries with GET 2013-08-29 11:52:29 -07:00
remarkup Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
search Restore search indexing to Ponder questions 2013-07-29 12:04:19 -07:00
storage Remove getApplicationObjectTypeName from ApplicationTransactions 2013-08-21 12:32:06 -07:00
view Update Form Layouts 2013-08-26 11:53:11 -07:00