1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 18:22:41 +01:00
phorge-phorge/src/applications/herald
Valerio Bozzolan 780e86acf8 Herald Rule Creation Page: fix Back button in some cases
Summary:
If you want to create a new Herald Rule, sometime,
like for new "Object" Herald Rules, the Back button just
sends you to the very same page you already were.

The risk is that an employee could receive a specific
instruction, such as "Hey Alfreda, Go back, now"
and at this point Alfreda goes into an incredible loop
continuing to click the Back button until the duration
of the universe (since Phorge is so stable that it's able
to handle that "Back spike" forever - really).

https://we.phorge.it/T15184

Note that this also tries to avoid to change the base URI
to just go Back. For example, before this change, the Back
button was trying to send from /create/ to /new/, but
apparently they are just aliases.

Closes T15184

Test Plan:
- Visit the page /herald/create/?adapter=commit
- Click on "Object"
- Click on "Back"
- Verify that you only went back one screen, and not just forward in time

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15184

Differential Revision: https://we.phorge.it/D25087
2023-03-27 20:54:28 +02:00
..
action Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them 2019-09-12 14:33:28 -07:00
adapter Provide a more structured result log for Herald conditions 2021-02-19 11:16:21 -08:00
application Separate Herald transcripts into several different views 2021-02-19 11:16:20 -08:00
capability Add skeleton code for webhooks 2018-02-09 13:55:04 -08:00
config Remove "HeraldRepetitionPolicyConfig" and hide storage details inside HeraldRule 2018-01-26 11:03:29 -08:00
contentsource Modularize content sources 2016-03-26 11:59:45 -07:00
controller Herald Rule Creation Page: fix Back button in some cases 2023-03-27 20:54:28 +02:00
edge On Harbormaster build plans, show which Herald rules trigger builds 2019-03-07 13:51:40 -08:00
editor Allow the Herald Rule Editor to apply generic "Edge" transactions 2020-01-15 08:29:46 -08:00
engine Provide a more structured result log for Herald rules 2021-02-19 11:16:22 -08:00
engineextension Index Herald fields, not just actions, when identifying objects related to a particular Herald rule 2019-09-09 12:50:43 -07:00
field Add a "Comment content" field to Herald 2020-10-16 13:42:56 -07:00
garbagecollector Refine core webhook implementation somewhat 2018-02-09 13:55:55 -08:00
group Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
mail Support Herald rules for Herald rules 2018-04-25 06:47:19 -07:00
management Add "--background" and "--count" flags to "bin/webhook call" 2020-06-25 18:05:58 -07:00
phid PHP 8.2: fixes for deprecated use of ${var} in strings 2023-03-26 22:08:22 +02:00
query Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
state Prepare TransactionEditor for silent transactions via bulk edit 2018-01-19 13:23:38 -08:00
storage Fix a PHP 8.1 unit test failure in Projects 2022-04-01 12:52:57 -07:00
typeahead Support querying Herald rules by monogram in typeahead datsources 2018-08-01 17:52:27 -07:00
value In Herald transcripts, render some field values in a more readable way 2020-01-29 15:14:06 -08:00
view On Harbormaster build plans, show which Herald rules trigger builds 2019-03-07 13:51:40 -08:00
worker In Webhooks, give errors human-readable labels and show reminder text for "Silent Mode" 2018-12-28 00:05:46 -08:00
xaction Modularize PhabricatorEditEngineConfigurationTransaction 2019-06-20 16:25:21 -07:00