1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 02:12:41 +01:00
phorge-phorge/src
epriestley fca534d6b6 Improve Asana API error handling in Doorkeeper
Summary:
Ref T2852. We need to distinguish between an API call which worked but got back nothing (404) and an API call which failed.

In particular, Asana hit a sync issue which was likely the result of treating a 500 (or some other error) as a 404.

Also clean up a couple small things.

Test Plan: Ran syncs against deleted tasks and saw successful syncs of non-tasks, and simulated random failures and saw them get handled correctly.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2852

Differential Revision: https://secure.phabricator.com/D6470
2013-07-16 10:29:52 -07:00
..
aphront Implement PhutilRequest parser #2 2013-06-24 08:22:26 -07:00
applications Improve Asana API error handling in Doorkeeper 2013-07-16 10:29:52 -07:00
docs Update mail documentation to point at the CLI tools 2013-07-10 18:52:42 -07:00
infrastructure Add explicit mysql.port configuration 2013-07-14 16:06:23 -07:00
view Build an early multi-step repository create form 2013-07-14 07:37:17 -07:00
__celerity_resource_map__.php Fixed voting comments bug on Ponder 2013-07-13 15:58:37 -07:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:51 -08:00
__phutil_library_map__.php Methods for reading reviewers from edges in differential 2013-07-14 19:18:56 -07:00