mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-11 09:22:40 +01:00
156b156e77
Summary: Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically. Put a `getX()` around the `defineX()` methods so the parent can provide default behaviors. Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general. Test Plan: - Ran `arc unit --everything`. - Called `conduit.query`. - Browsed Conduit UI. Reviewers: btrahan Reviewed By: btrahan Subscribers: hach-que, epriestley Maniphest Tasks: T5873, T7803 Differential Revision: https://secure.phabricator.com/D12380
75 lines
1.9 KiB
PHP
75 lines
1.9 KiB
PHP
<?php
|
|
|
|
final class ManiphestGetTaskTransactionsConduitAPIMethod
|
|
extends ManiphestConduitAPIMethod {
|
|
|
|
public function getAPIMethodName() {
|
|
return 'maniphest.gettasktransactions';
|
|
}
|
|
|
|
public function getMethodDescription() {
|
|
return 'Retrieve Maniphest Task Transactions.';
|
|
}
|
|
|
|
protected function defineParamTypes() {
|
|
return array(
|
|
'ids' => 'required list<int>',
|
|
);
|
|
}
|
|
|
|
protected function defineReturnType() {
|
|
return 'nonempty list<dict<string, wild>>';
|
|
}
|
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
|
$results = array();
|
|
$task_ids = $request->getValue('ids');
|
|
|
|
if (!$task_ids) {
|
|
return $results;
|
|
}
|
|
|
|
$tasks = id(new ManiphestTaskQuery())
|
|
->setViewer($request->getUser())
|
|
->withIDs($task_ids)
|
|
->execute();
|
|
$tasks = mpull($tasks, null, 'getPHID');
|
|
|
|
$transactions = array();
|
|
if ($tasks) {
|
|
$transactions = id(new ManiphestTransactionQuery())
|
|
->setViewer($request->getUser())
|
|
->withObjectPHIDs(mpull($tasks, 'getPHID'))
|
|
->needComments(true)
|
|
->execute();
|
|
}
|
|
|
|
foreach ($transactions as $transaction) {
|
|
$task_phid = $transaction->getObjectPHID();
|
|
if (empty($tasks[$task_phid])) {
|
|
continue;
|
|
}
|
|
|
|
$task_id = $tasks[$task_phid]->getID();
|
|
|
|
$comments = null;
|
|
if ($transaction->hasComment()) {
|
|
$comments = $transaction->getComment()->getContent();
|
|
}
|
|
|
|
$results[$task_id][] = array(
|
|
'taskID' => $task_id,
|
|
'transactionPHID' => $transaction->getPHID(),
|
|
'transactionType' => $transaction->getTransactionType(),
|
|
'oldValue' => $transaction->getOldValue(),
|
|
'newValue' => $transaction->getNewValue(),
|
|
'comments' => $comments,
|
|
'authorPHID' => $transaction->getAuthorPHID(),
|
|
'dateCreated' => $transaction->getDateCreated(),
|
|
);
|
|
}
|
|
|
|
return $results;
|
|
}
|
|
|
|
}
|