1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 03:12:41 +01:00
phorge-phorge/src/view/layout
epriestley f02aed10e7 Fix three issues with scrolling while dragging items (e.g., on workboards)
Summary:
Fixes T5979. There are three issues here:

  - We cache document positions when you pick an item up, but don't recalculate them after you scroll, so they get out of date. Dirty the cache when the user scrolls.
  - When we rebuild the cache during a drag (previously, this never happened), the position of the object you're dragging is computed wrong (since it has been moved to be under the cursor). Adjust the effective position of the object you've picked up to put it back in the right place in the list.
  - When you fiddle around at the bottom of a column you can get jumpy redraws as the height adjusts. Put `min-height` on the container during a drag to prevent this.

Test Plan: In Safari, Chrome and Firefox, dragged items around on columns before and after scrolling the workboard panel.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5979

Differential Revision: https://secure.phabricator.com/D10455
2014-09-09 14:20:27 -07:00
..
__tests__ Added some additional assertion methods. 2014-03-08 19:16:21 -08:00
AphrontContextBarView.php Replace some hsprintf() with phutil_tag() and phutil_tag_div() Depends on D7545. 2013-11-09 10:48:19 -08:00
AphrontListFilterView.php Fix shadown on aphront filter viewy 2013-07-03 09:25:05 -07:00
AphrontMiniPanelView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
AphrontMoreView.php render_tag -> tag: fix more callsites (more view, misc) 2013-01-31 09:08:02 -08:00
AphrontMultiColumnView.php Fix three issues with scrolling while dragging items (e.g., on workboards) 2014-09-09 14:20:27 -07:00
AphrontPanelView.php Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
AphrontSideNavFilterView.php Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
AphrontTwoColumnView.php Phriction Redesign 2013-04-11 15:05:50 -07:00
PhabricatorActionListView.php Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
PhabricatorActionView.php Move icon inside link in ActionLink 2014-06-12 11:27:30 -07:00
PhabricatorAnchorView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorCrumbsView.php Replace Sprite-Icons with FontAwesome 2014-05-12 10:08:32 -07:00
PhabricatorCrumbView.php Add aural label for "application" breadcrumb in crumbs 2014-05-01 08:55:45 -07:00
PhabricatorFileLinkListView.php Various linter fixes. 2014-02-26 12:44:58 -08:00
PhabricatorFileLinkView.php Conpherence - make the files widget purdy-ish 2013-03-15 23:41:36 -07:00
PhabricatorSourceCodeView.php Applied various linter fixes. 2014-06-09 16:04:12 -07:00
PhabricatorTransactionView.php Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00