mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-25 06:50:55 +01:00
6039ca6fb5
Summary: This adds support to differential fields to display warnings before a revision gets accepted. Since lint and unit are differential fields, the code for their warnings was moved into their respective field specification classes, so there is only one code path for warnings (lint, unit, or custom). Test Plan: Select 'Accept' on a revision with lint/unit warnings and see messages appear like they used to. Change it back to 'Comment' and they go away. Repeat with a revision without lint/unit warnings and see no warnings appear. Checked darkconsole to see no errors due to this. Reviewers: jungejason, epriestley, vrana Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2363 |
||
|---|---|---|
| .. | ||
| behavior-accept-with-errors.js | ||
| behavior-add-reviewers-and-ccs.js | ||
| behavior-comment-jump.js | ||
| behavior-comment-preview.js | ||
| behavior-diff-radios.js | ||
| behavior-dropdown-menus.js | ||
| behavior-edit-inline-comments.js | ||
| behavior-keyboard-nav.js | ||
| behavior-populate.js | ||
| behavior-show-all-comments.js | ||
| behavior-show-field-details.js | ||
| behavior-show-more.js | ||
| behavior-user-select.js | ||
| DifferentialInlineCommentEditor.js | ||