mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-27 01:02:42 +01:00
ea67a8ab8e
Summary: Fixes T7033. When we've reframed the main page content we need to scroll relative to the containing frame, not relative to the window. Test Plan: In Safari, Chrome and Firefox, used j/k/J/K keys to navigate diff content. Tried some other scroll-based beahviors, like jump-to-anchors. (It looks like the highlighting reticle got slightly derped a while ago, but it's still functional, so I didn't mess with it.) Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7033 Differential Revision: https://secure.phabricator.com/D11490
121 lines
2.9 KiB
JavaScript
121 lines
2.9 KiB
JavaScript
/**
|
|
* @provides javelin-behavior-releeph-request-state-change
|
|
* @requires javelin-behavior
|
|
* javelin-dom
|
|
* javelin-stratcom
|
|
* javelin-workflow
|
|
* javelin-util
|
|
* phabricator-keyboard-shortcut
|
|
*/
|
|
|
|
JX.behavior('releeph-request-state-change', function() {
|
|
function getRequestHeaderNodes() {
|
|
return JX.DOM.scry(document.body, 'div', 'releeph-request-box');
|
|
}
|
|
|
|
var keynav_cursor = -1;
|
|
|
|
function keynavJump(manager, delta) {
|
|
// Calculate this everytime, because the DOM changes.
|
|
var headers = getRequestHeaderNodes();
|
|
keynav_cursor += delta;
|
|
|
|
if (keynav_cursor < 0) {
|
|
keynav_cursor = -1;
|
|
JX.DOM.scrollToPosition(0, 0);
|
|
keynavMarkup();
|
|
return;
|
|
}
|
|
|
|
if (keynav_cursor >= headers.length) {
|
|
keynav_cursor = headers.length - 1;
|
|
}
|
|
|
|
var focus = headers[keynav_cursor];
|
|
manager.scrollTo(focus);
|
|
|
|
keynavMarkup();
|
|
}
|
|
|
|
function keynavMarkup() {
|
|
var headers = getRequestHeaderNodes();
|
|
for (var k in headers) {
|
|
JX.DOM.alterClass(headers[k], 'focus', k == keynav_cursor);
|
|
}
|
|
}
|
|
|
|
function keynavAction(manager, action_name) {
|
|
var headers = getRequestHeaderNodes();
|
|
var header = headers[keynav_cursor];
|
|
|
|
if (keynav_cursor < 0) {
|
|
return;
|
|
}
|
|
|
|
var sigil = action_name;
|
|
var button = JX.DOM.find(header, 'a', sigil);
|
|
if (button) {
|
|
button.click();
|
|
}
|
|
}
|
|
|
|
function keynavNavigateToRequestPage() {
|
|
var headers = getRequestHeaderNodes();
|
|
var header = headers[keynav_cursor];
|
|
window.open(JX.Stratcom.getData(header).uri);
|
|
}
|
|
|
|
new JX.KeyboardShortcut('j', 'Jump to next request.')
|
|
.setHandler(function(manager) {
|
|
keynavJump(manager, +1);
|
|
})
|
|
.register();
|
|
|
|
new JX.KeyboardShortcut('k', 'Jump to previous request.')
|
|
.setHandler(function(manager) {
|
|
keynavJump(manager, -1);
|
|
})
|
|
.register();
|
|
|
|
new JX.KeyboardShortcut('a', 'Approve the selected request.')
|
|
.setHandler(function(manager) {
|
|
keynavAction(manager, 'want');
|
|
})
|
|
.register();
|
|
|
|
new JX.KeyboardShortcut('r', 'Reject the selected request.')
|
|
.setHandler(function(manager) {
|
|
keynavAction(manager, 'pass');
|
|
})
|
|
.register();
|
|
|
|
new JX.KeyboardShortcut(
|
|
['g', 'return'],
|
|
'Open selected request\'s page in a new tab.')
|
|
.setHandler(function() {
|
|
keynavNavigateToRequestPage();
|
|
})
|
|
.register();
|
|
|
|
function onresponse(box, response) {
|
|
JX.DOM.replace(box, JX.$H(response.markup));
|
|
keynavMarkup();
|
|
}
|
|
|
|
JX.Stratcom.listen(
|
|
'click',
|
|
'releeph-request-state-change',
|
|
function(e) {
|
|
e.kill();
|
|
|
|
var box = e.getNode('releeph-request-box');
|
|
var link = e.getNode('releeph-request-state-change');
|
|
|
|
box.style.opacity = '0.5';
|
|
|
|
JX.Workflow.newFromLink(link)
|
|
.setData({render: true})
|
|
.setHandler(JX.bind(null, onresponse, box))
|
|
.start();
|
|
});
|
|
});
|