1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
phorge-phorge/webroot/rsrc
epriestley fe66d52a22 Don't copy null attributes passed to JX.$N()
Summary:
Fixes T8919. In Safari, `node.href = null;` has no effect, but in Chrome it is like `node.href = "null";`.

Instead, just use semantics similar to `phutil_tag()`: don't assign attributes with `null` values.

Test Plan:
No more `/null` href in Chrome in Owners typehaead.

Typeahead still works in Chrome/Safari.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8919

Differential Revision: https://secure.phabricator.com/D14021
2015-08-31 15:52:04 -07:00
..
css Update bar colors to match icon colors 2015-08-31 14:51:51 -07:00
externals Don't copy null attributes passed to JX.$N() 2015-08-31 15:52:04 -07:00
favicons Add HiDPI favicons 2014-11-07 17:07:38 -08:00
image Update login icons 2015-07-16 17:14:50 -07:00
js Symbol Search: Allow ctrl-click with no hover 2015-08-27 04:17:38 -07:00