mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-01 19:22:42 +01:00
fe9ba6bc67
Summary: - We currently post-filter by branches, but should do this in SQL. See T799. - We currently identify branch-name-matches as being in the working copy even if they belong to a different project (e.g., two different projects with commits on the branch "master"). See T1100. - Denormalize branch and project information into DifferentialRevision. - Expose project information in the API. Test Plan: Ran conduit API queries with branches and arc project IDs, got reasonable results. Reviewers: btrahan, vrana, jungejason Reviewed By: btrahan CC: aran Maniphest Tasks: T1100, T799 Differential Revision: https://secure.phabricator.com/D2190
229 lines
5.9 KiB
PHP
229 lines
5.9 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright 2012 Facebook, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
final class DifferentialRevision extends DifferentialDAO {
|
|
|
|
protected $title;
|
|
protected $status;
|
|
|
|
protected $summary;
|
|
protected $testPlan;
|
|
|
|
protected $phid;
|
|
protected $authorPHID;
|
|
protected $lastReviewerPHID;
|
|
|
|
protected $dateCommitted;
|
|
|
|
protected $lineCount;
|
|
protected $attached = array();
|
|
protected $unsubscribed = array();
|
|
|
|
protected $mailKey;
|
|
protected $branchName;
|
|
protected $arcanistProjectPHID;
|
|
|
|
private $relationships;
|
|
private $commits;
|
|
private $activeDiff = false;
|
|
private $diffIDs;
|
|
|
|
|
|
const RELATIONSHIP_TABLE = 'differential_relationship';
|
|
const TABLE_COMMIT = 'differential_commit';
|
|
|
|
const RELATION_REVIEWER = 'revw';
|
|
const RELATION_SUBSCRIBED = 'subd';
|
|
|
|
public function getConfiguration() {
|
|
return array(
|
|
self::CONFIG_AUX_PHID => true,
|
|
self::CONFIG_SERIALIZATION => array(
|
|
'attached' => self::SERIALIZATION_JSON,
|
|
'unsubscribed' => self::SERIALIZATION_JSON,
|
|
),
|
|
) + parent::getConfiguration();
|
|
}
|
|
|
|
public function loadCommitPHIDs() {
|
|
if (!$this->getID()) {
|
|
return ($this->commits = array());
|
|
}
|
|
|
|
$commits = queryfx_all(
|
|
$this->establishConnection('r'),
|
|
'SELECT commitPHID FROM %T WHERE revisionID = %d',
|
|
self::TABLE_COMMIT,
|
|
$this->getID());
|
|
$commits = ipull($commits, 'commitPHID');
|
|
|
|
return ($this->commits = $commits);
|
|
}
|
|
|
|
public function getCommitPHIDs() {
|
|
if ($this->commits === null) {
|
|
throw new Exception("Must attach commits first!");
|
|
}
|
|
return $this->commits;
|
|
}
|
|
|
|
public function getActiveDiff() {
|
|
// TODO: Because it's currently technically possible to create a revision
|
|
// without an associated diff, we allow an attached-but-null active diff.
|
|
// It would be good to get rid of this once we make diff-attaching
|
|
// transactional.
|
|
|
|
if ($this->activeDiff === false) {
|
|
throw new Exception("Must attach active diff first!");
|
|
}
|
|
return $this->activeDiff;
|
|
}
|
|
|
|
public function attachActiveDiff($diff) {
|
|
$this->activeDiff = $diff;
|
|
return $this;
|
|
}
|
|
|
|
public function getDiffIDs() {
|
|
if ($this->diffIDs === null) {
|
|
throw new Exception("Must attach diff IDs first!");
|
|
}
|
|
return $this->diffIDs;
|
|
}
|
|
|
|
public function attachDiffIDs(array $ids) {
|
|
rsort($ids);
|
|
$this->diffIDs = array_values($ids);
|
|
return $this;
|
|
}
|
|
|
|
public function attachCommitPHIDs(array $phids) {
|
|
$this->commits = array_values($phids);
|
|
return $this;
|
|
}
|
|
|
|
public function getAttachedPHIDs($type) {
|
|
return array_keys(idx($this->attached, $type, array()));
|
|
}
|
|
|
|
public function setAttachedPHIDs($type, array $phids) {
|
|
$this->attached[$type] = array_fill_keys($phids, array());
|
|
return $this;
|
|
}
|
|
|
|
public function generatePHID() {
|
|
return PhabricatorPHID::generateNewPHID(
|
|
PhabricatorPHIDConstants::PHID_TYPE_DREV);
|
|
}
|
|
|
|
public function loadDiffs() {
|
|
if (!$this->getID()) {
|
|
return array();
|
|
}
|
|
return id(new DifferentialDiff())->loadAllWhere(
|
|
'revisionID = %d',
|
|
$this->getID());
|
|
}
|
|
|
|
public function loadComments() {
|
|
if (!$this->getID()) {
|
|
return array();
|
|
}
|
|
return id(new DifferentialComment())->loadAllWhere(
|
|
'revisionID = %d',
|
|
$this->getID());
|
|
}
|
|
|
|
public function loadActiveDiff() {
|
|
return id(new DifferentialDiff())->loadOneWhere(
|
|
'revisionID = %d ORDER BY id DESC LIMIT 1',
|
|
$this->getID());
|
|
}
|
|
|
|
public function save() {
|
|
if (!$this->getMailKey()) {
|
|
$this->mailKey = Filesystem::readRandomCharacters(40);
|
|
}
|
|
return parent::save();
|
|
}
|
|
|
|
public function loadRelationships() {
|
|
if (!$this->getID()) {
|
|
$this->relationships = array();
|
|
return;
|
|
}
|
|
|
|
$data = queryfx_all(
|
|
$this->establishConnection('r'),
|
|
'SELECT * FROM %T WHERE revisionID = %d ORDER BY sequence',
|
|
self::RELATIONSHIP_TABLE,
|
|
$this->getID());
|
|
|
|
return $this->attachRelationships($data);
|
|
}
|
|
|
|
public function attachRelationships(array $relationships) {
|
|
$this->relationships = igroup($relationships, 'relation');
|
|
return $this;
|
|
}
|
|
|
|
public function getReviewers() {
|
|
return $this->getRelatedPHIDs(self::RELATION_REVIEWER);
|
|
}
|
|
|
|
public function getCCPHIDs() {
|
|
return $this->getRelatedPHIDs(self::RELATION_SUBSCRIBED);
|
|
}
|
|
|
|
private function getRelatedPHIDs($relation) {
|
|
if ($this->relationships === null) {
|
|
throw new Exception("Must load relationships!");
|
|
}
|
|
|
|
return ipull($this->getRawRelations($relation), 'objectPHID');
|
|
}
|
|
|
|
public function getRawRelations($relation) {
|
|
return idx($this->relationships, $relation, array());
|
|
}
|
|
|
|
public function getUnsubscribedPHIDs() {
|
|
return array_keys($this->getUnsubscribed());
|
|
}
|
|
|
|
public function loadReviewedBy() {
|
|
$reviewer = null;
|
|
|
|
if ($this->status == ArcanistDifferentialRevisionStatus::ACCEPTED ||
|
|
$this->status == ArcanistDifferentialRevisionStatus::COMMITTED) {
|
|
$comments = $this->loadComments();
|
|
foreach ($comments as $comment) {
|
|
$action = $comment->getAction();
|
|
if ($action == DifferentialAction::ACTION_ACCEPT) {
|
|
$reviewer = $comment->getAuthorPHID();
|
|
} else if ($action == DifferentialAction::ACTION_REJECT ||
|
|
$action == DifferentialAction::ACTION_ABANDON ||
|
|
$action == DifferentialAction::ACTION_RETHINK) {
|
|
$reviewer = null;
|
|
}
|
|
}
|
|
}
|
|
|
|
return $reviewer;
|
|
}
|
|
}
|