1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-02 18:08:26 +01:00
phorge-phorge/src/infrastructure/env
epriestley 1ee426e4ac Add a specialized cache for storing "has setup ever worked?"
Summary:
Ref T11613. In D16503/T11598 I refined the setup flow to improve messaging for early-stage setup issues, but failed to fully untangle things.

We sometimes still try to access a cache which uses configuration before we build configuration, which causes an error.

Instead, store "are we in flight / has setup ever worked?" in a separate cache which doesn't use the cache namespace. This stops us from trying to read config before building config.

Test Plan:
Hit bad extension error with a fake extension, got a proper setup help page:

{F1812803}

Solved the error, reloaded, broke things again, got a "friendly" page:

{F1812805}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11613

Differential Revision: https://secure.phabricator.com/D16542
2016-09-12 08:04:32 -07:00
..
__tests__ phtize all the things 2015-05-22 21:16:39 +10:00
PhabricatorConfigDatabaseSource.php Add database configuration source to the source stack 2013-01-17 15:10:21 -08:00
PhabricatorConfigDefaultSource.php Read default values of custom config options 2013-01-19 08:36:08 -08:00
PhabricatorConfigDictionarySource.php Formalize configuration sources and source stacks 2012-12-25 06:44:29 -08:00
PhabricatorConfigFileSource.php phtize all the things 2015-05-22 21:16:39 +10:00
PhabricatorConfigLocalSource.php phtize all the things 2015-05-22 21:16:39 +10:00
PhabricatorConfigProxySource.php phtize all the things 2015-05-22 21:16:39 +10:00
PhabricatorConfigSiteSource.php Add an extensible "SiteSource" for configuration 2014-11-05 15:30:40 -08:00
PhabricatorConfigSource.php Extend from Phobject 2015-06-15 18:02:27 +10:00
PhabricatorConfigStackSource.php phtize all the things 2015-05-22 21:16:39 +10:00
PhabricatorEnv.php Add a specialized cache for storing "has setup ever worked?" 2016-09-12 08:04:32 -07:00
PhabricatorScopedEnv.php Extend from Phobject 2015-06-15 18:02:27 +10:00