From 5a9af95f85a7e5d4f9c10cb8cf737651a921f1d1 Mon Sep 17 00:00:00 2001 From: Lasse Collin Date: Tue, 26 Sep 2023 21:47:13 +0300 Subject: [PATCH] liblzma: Update a comment. The C standards don't allow an empty translation unit which can be avoided by declaring something, without exporting any symbols. When I committed f644473a211394447824ea00518d0a214ff3f7f2 I had a feeling that some specific toolchain somewhere didn't like empty object files (assembler or maybe "ar" complained) but I cannot find anything to confirm this now. Quite likely I remembered nonsense. I leave this here as a note to my future self. :-) --- src/liblzma/check/crc64_table.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/liblzma/check/crc64_table.c b/src/liblzma/check/crc64_table.c index 6f9adb04..688e527b 100644 --- a/src/liblzma/check/crc64_table.c +++ b/src/liblzma/check/crc64_table.c @@ -18,8 +18,7 @@ #if (defined(__x86_64__) && defined(__SSSE3__) \ && defined(__SSE4_1__) && defined(__PCLMUL__)) \ || (defined(__e2k__) && __iset__ >= 6) -// No table needed but something has to be exported to keep some toolchains -// happy. Also use a declaration to silence compiler warnings. +// No table needed. Use a typedef to avoid an empty translation unit. typedef void lzma_crc64_dummy; #else