revi-archive/xz-archive
1
0
Fork 0
mirror of https://git.tukaani.org/xz.git synced 2024-04-04 12:36:23 +02:00
Code Activity

xz: Change logging level for thread reduction to highest verbosity only.

Browse source 
Now that multi threaded encoding is the default, users do not need to
see a warning message everytime the number of threads is reduced. On
some machines, this could happen very often. It is not unreasonable for
users to need to set double verbose mode to see this kind of
information.

To see these warning messages -vv or --verbose --verbose must be passed
to set xz into the highest possible verbosity mode.

These warnings had caused automated testing frameworks to fail when they
expected no output to stderr.

Thanks to Sebastian Andrzej Siewior for reporting this and for the
initial version of the patch.
This commit is contained in:
Jia Tan 2024-02-27 23:42:41 +08:00 committed by Lasse Collin
parent d0e57b2f15
commit 5c91b454c2
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/xz/coder.c
View file

@ -581,7 +581,7 @@ coder_set_compression_settings(void)
if (memory_usage <= memory_limit) { if (memory_usage <= memory_limit) {
// The memory usage is now low enough. // The memory usage is now low enough.
message(V_WARNING, _("Reduced the number of " message(V_DEBUG, _("Reduced the number of "
"threads from %s to %s to not exceed " "threads from %s to %s to not exceed "
"the memory usage limit of %s MiB"), "the memory usage limit of %s MiB"),
uint64_to_str( uint64_to_str(
@ -601,7 +601,7 @@ coder_set_compression_settings(void)
// time the soft limit will never make xz fail and never make // time the soft limit will never make xz fail and never make
// xz change settings that would affect the compressed output. // xz change settings that would affect the compressed output.
if (hardware_memlimit_mtenc_is_default()) { if (hardware_memlimit_mtenc_is_default()) {
message(V_WARNING, _("Reduced the number of threads " message(V_DEBUG, _("Reduced the number of threads "
"from %s to one. The automatic memory usage " "from %s to one. The automatic memory usage "
"limit of %s MiB is still being exceeded. " "limit of %s MiB is still being exceeded. "
"%s MiB of memory is required. " "%s MiB of memory is required. "