From 03ebd1bbb314f9f204940219a835c883bf442475 Mon Sep 17 00:00:00 2001 From: Lasse Collin Date: Wed, 26 Jan 2011 12:19:08 +0200 Subject: [PATCH 1/2] xz: Fix --force on setuid/setgid/sticky and multi-hardlink files. xz didn't compress setuid/setgid/sticky files and files with multiple hard links even with --force. This bug was introduced in 23ac2c44c3ac76994825adb7f9a8f719f78b5ee4. Thanks to Charles Wilson. --- src/xz/file_io.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/xz/file_io.c b/src/xz/file_io.c index 6e24c58a..09edcca6 100644 --- a/src/xz/file_io.c +++ b/src/xz/file_io.c @@ -457,15 +457,14 @@ io_open_src_real(file_pair *pair) goto error; } - if (reg_files_only) { - if (!S_ISREG(pair->src_st.st_mode)) { - message_warning(_("%s: Not a regular file, " - "skipping"), pair->src_name); - goto error; - } + if (reg_files_only && !S_ISREG(pair->src_st.st_mode)) { + message_warning(_("%s: Not a regular file, skipping"), + pair->src_name); + goto error; + } - // These are meaningless on Windows. #ifndef TUKLIB_DOSLIKE + if (reg_files_only && !opt_force) { if (pair->src_st.st_mode & (S_ISUID | S_ISGID)) { // gzip rejects setuid and setgid files even // when --force was used. bzip2 doesn't check @@ -495,8 +494,8 @@ io_open_src_real(file_pair *pair) "skipping"), pair->src_name); goto error; } -#endif } +#endif return false; From 5fbce0b8d96dc96775aa0215e3581addc830e23d Mon Sep 17 00:00:00 2001 From: Lasse Collin Date: Fri, 28 Jan 2011 20:16:57 +0200 Subject: [PATCH 2/2] Update NEWS for 5.0.1. --- NEWS | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/NEWS b/NEWS index d9a2f3cf..3ef11201 100644 --- a/NEWS +++ b/NEWS @@ -2,6 +2,20 @@ XZ Utils User-Visible Changes ============================= +5.0.1 (2011-01-29) + + * xz --force now (de)compresses files that have setuid, setgid, + or sticky bit set and files that have multiple hard links. + The man page had it documented this way already, but the code + had a bug. + + * gzip and bzip2 support in xzdiff was fixed. + + * Portability fixes + + * Minor fix to Czech translation + + 5.0.0 (2010-10-23) Only the most important changes compared to 4.999.9beta are listed