revi-archive/xz-archive
1
0
Fork 0
mirror of https://git.tukaani.org/xz.git synced 2024-04-04 12:36:23 +02:00
Code Activity

xz: If input file cannot be removed, treat it as a warning, not error.

Browse source 
Treating it as a warning (message + exit status 2) matches gzip
and it seems more logical as at that point the output file has
already been successfully closed. When it's a warning it is
possible to suppress it with --no-warn.
This commit is contained in:
Lasse Collin 2022-10-25 18:23:54 +03:00
parent fda9f85f52
commit 8562401597
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/xz/file_io.c
View file

@ -330,14 +330,14 @@ io_unlink(const char *name, const struct stat *known_st)
// it is possible that the user has put a new file in place // it is possible that the user has put a new file in place
// of the original file, and in that case it obviously // of the original file, and in that case it obviously
// shouldn't be removed. // shouldn't be removed.
message_error(_("%s: File seems to have been moved, " message_warning(_("%s: File seems to have been moved, "
"not removing"), name); "not removing"), name);
else else
#endif #endif
// There's a race condition between lstat() and unlink() // There's a race condition between lstat() and unlink()
// but at least we have tried to avoid removing wrong file. // but at least we have tried to avoid removing wrong file.
if (unlink(name)) if (unlink(name))
message_error(_("%s: Cannot remove: %s"), message_warning(_("%s: Cannot remove: %s"),
name, strerror(errno)); name, strerror(errno));
return; return;