revi-archive/xz-archive
1
0
Fork 0
mirror of https://git.tukaani.org/xz.git synced 2024-04-04 12:36:23 +02:00
Code Activity

xz: Avoid fchown(2) failure.

Browse source 
OpenBSD does not allow to change the group of a file if the user
does not belong to this group.  In contrast to Linux, OpenBSD also
fails if the new group is the same as the old one.  Do not call
fchown(2) in this case, it would change nothing anyway.

This fixes an issue with Perl Alien::Build module.
https://github.com/PerlAlien/Alien-Build/issues/62
This commit is contained in:
Alexander Bluhm 2021-10-05 23:33:16 +02:00 committed by Lasse Collin
parent 2b509c868c
commit 892b16cc28
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/xz/file_io.c
View file

@ -368,7 +368,13 @@ io_copy_attrs(const file_pair *pair)
mode_t mode;
if (fchown(pair->dest_fd, (uid_t)(-1), pair->src_st.st_gid)) {
// With BSD semantics the new dest file may have a group that
// does not belong to the user. If the src file has the same gid
// nothing has to be done. Nevertheless OpenBSD fchown(2) fails
// in this case which seems to be POSIX compliant. As there is
// nothing to do, skip the system call.
if (pair->dest_st.st_gid != pair->src_st.st_gid &&
fchown(pair->dest_fd, (uid_t)(-1), pair->src_st.st_gid)) {
message_warning(_("%s: Cannot set the file group: %s"),
pair->dest_name, strerror(errno));
// We can still safely copy some additional permissions: