From 8c36ab79cbf23104ce7a3d533d5ac98cd492e57c Mon Sep 17 00:00:00 2001 From: Lasse Collin Date: Mon, 30 Oct 2023 18:09:53 +0200 Subject: [PATCH] liblzma: Add a note why crc_always_inline exists for now. Solaris Studio is a possible example (not tested) which supports the always_inline attribute but might not get detected by the common.h #ifdefs. --- src/liblzma/check/crc_common.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/liblzma/check/crc_common.h b/src/liblzma/check/crc_common.h index 1783b5e7..4764eb17 100644 --- a/src/liblzma/check/crc_common.h +++ b/src/liblzma/check/crc_common.h @@ -48,6 +48,11 @@ // If both __forceinline and inline are used, MSVC will issue a warning. // Since MSVC's keyword is a replacement keyword, the lzma_always_inline // macro must also contain the inline keyword when its not used in MSVC. +// +// NOTE: This doesn't use lzma_always_inline for now as support for it is +// detected using preprocessor macros which might miss a compiler that +// does support it. All compilers that support the CLMUL code support +// the attribute too; if not, we will hopefully get a bug report. #ifdef _MSC_VER # define crc_always_inline __forceinline #else