revi-archive/xz-archive
1
0
Fork 0
mirror of https://git.tukaani.org/xz.git synced 2024-04-04 12:36:23 +02:00
Code Activity

liblzma: Initialize lzma_lz_encoder pointers with NULL.

Browse source 
This fixes the recent change to lzma_lz_encoder that used memzero
instead of the NULL constant. On some compilers the NULL constant
(always 0) may not equal the NULL pointer (this only needs to guarentee
to not point to valid memory address).

Later code compares the pointers to the NULL pointer so we must
initialize them with the NULL pointer instead of 0 to guarentee
code correctness.
This commit is contained in:
Jia Tan 2023-12-20 21:31:34 +08:00
parent 183a62f0b5
commit b34b6a9912
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/liblzma/lz/lz_encoder.c
View file

@ -564,7 +564,11 @@ lzma_lz_encoder_init(lzma_next_coder *next, const lzma_allocator *allocator,
next->update = &lz_encoder_update; next->update = &lz_encoder_update;
next->set_out_limit = &lz_encoder_set_out_limit; next->set_out_limit = &lz_encoder_set_out_limit;
memzero((&coder->lz), sizeof(lzma_lz_encoder)); coder->lz.coder = NULL;
coder->lz.code = NULL;
coder->lz.end = NULL;
coder->lz.options_update = NULL;
coder->lz.set_out_limit = NULL;
// mf.size is initialized to silence Valgrind // mf.size is initialized to silence Valgrind
// when used on optimized binaries (GCC may reorder // when used on optimized binaries (GCC may reorder