revi-archive/xz-archive
1
0
Fork 0
mirror of https://git.tukaani.org/xz.git synced 2024-04-04 12:36:23 +02:00
Code Activity

Fix too small static buffer in util.c.

Browse source 
This was introduced in
0dd6d00766 two days ago.
This commit is contained in:
Lasse Collin 2010-01-26 15:42:24 +02:00
parent d0b4bbf5da
commit d9a9800597
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/xz/util.c
View file

@ -175,13 +175,14 @@ uint64_to_nicestr(uint64_t value, enum nicestr_unit unit_min,
static const char suffix[5][4] = { "B", "KiB", "MiB", "GiB", "TiB" }; static const char suffix[5][4] = { "B", "KiB", "MiB", "GiB", "TiB" };
// Minimum buffer size: // Minimum buffer size:
// 11 "1,234.5 MiB" // 26 2^64 with thousand separators
// 4 " KiB"
// 2 " (" // 2 " ("
// 26 2^64 with thousand separators // 26 2^64 with thousand separators
// 3 " B)" // 3 " B)"
// 1 '\0' // 1 '\0'
// 43 Total // 62 Total
static char buf[4][44]; static char buf[4][64];
char *pos = buf[slot]; char *pos = buf[slot];
size_t left = sizeof(buf[slot]); size_t left = sizeof(buf[slot]);
my_snprintf(&pos, &left, "%s %s", str, suffix[unit]); my_snprintf(&pos, &left, "%s %s", str, suffix[unit]);
@ -196,8 +197,6 @@ uint64_to_nicestr(uint64_t value, enum nicestr_unit unit_min,
extern const char * extern const char *
double_to_str(double value) double_to_str(double value)
{ {
// 64 bytes is surely enough, since it won't fit in some other
// fields anyway.
static char buf[64]; static char buf[64];
static enum { UNKNOWN, WORKS, BROKEN } thousand = UNKNOWN; static enum { UNKNOWN, WORKS, BROKEN } thousand = UNKNOWN;