revi-archive/xz-archive
1
0
Fork 0
mirror of https://git.tukaani.org/xz.git synced 2024-04-04 12:36:23 +02:00
Code Activity

Don't call close(-1) in tuklib_open_stdxxx() on error.

Browse source 
Thanks to Jim Meyering.
This commit is contained in:
Lasse Collin 2011-05-28 16:43:26 +03:00
parent bd35d903a0
commit fc4d443696
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/common/tuklib_open_stdxxx.c
View file

@ -39,12 +39,14 @@ tuklib_open_stdxxx(int err_status)
| (i == 0 ? O_WRONLY : O_RDONLY)); | (i == 0 ? O_WRONLY : O_RDONLY));
if (fd != i) { if (fd != i) {
if (fd != -1)
(void)close(fd);
// Something went wrong. Exit with the // Something went wrong. Exit with the
// exit status we were given. Don't try // exit status we were given. Don't try
// to print an error message, since stderr // to print an error message, since stderr
// may very well be non-existent. This // may very well be non-existent. This
// error should be extremely rare. // error should be extremely rare.
(void)close(fd);
exit(err_status); exit(err_status);
} }
} }