diff --git a/.arcconfig b/.arcconfig index 97b14f4..5a0f3d3 100644 --- a/.arcconfig +++ b/.arcconfig @@ -1,3 +1,4 @@ { - "phabricator.uri": "https://issuetracker.revi.xyz" + "phabricator.uri": "https://issuetracker.revi.xyz", + "load": [".pinterest-linters"] } diff --git a/.arclint b/.arclint index 8f68362..d754535 100644 --- a/.arclint +++ b/.arclint @@ -53,6 +53,10 @@ "3": "disabled", "5": "disabled" } + }, + "yaml lint": { + "type": "yamllint", + "include": ["(\\.yaml$)", "(\\.yml$)", "(^.yamllint$)"] } } } diff --git a/.gitattributes b/.gitattributes index 0306584..b189ffa 100644 --- a/.gitattributes +++ b/.gitattributes @@ -19,5 +19,5 @@ # GitHub Linguist detection # https://github.com/github-linguist/linguist/blob/master/docs/overrides.md -.arclint linguist-language=json -.yamllint linguist-language=yaml +.arclint linguist-language=json +.yamllint linguist-language=yaml diff --git a/.github/workflows/quicksyntaxcheck.yml b/.github/workflows/quicksyntaxcheck.yml index 2bc7924..cc3d806 100644 --- a/.github/workflows/quicksyntaxcheck.yml +++ b/.github/workflows/quicksyntaxcheck.yml @@ -12,5 +12,7 @@ jobs: phpsyntax: runs-on: ubuntu-latest steps: + - name: Checkout + uses: actions/checkout@v4 - name: PHP Basic Syntax Check run: php -l {{ $github.workspace }}/PhabExt/PhabricatorCustomRobotsTxtController.php diff --git a/.github/workflows/yamlLint.yml b/.github/workflows/yamlLint.yml index 799150c..c148a49 100644 --- a/.github/workflows/yamlLint.yml +++ b/.github/workflows/yamlLint.yml @@ -14,9 +14,10 @@ on: workflow_dispatch: jobs: - lint-everything: + yaml-lint: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - name: Checkout + uses: actions/checkout@v4 - name: yaml-lint uses: ibiqlik/action-yamllint@v3 diff --git a/.gitmodules b/.gitmodules new file mode 100644 index 0000000..bafd571 --- /dev/null +++ b/.gitmodules @@ -0,0 +1,5 @@ +# @generated +# This file was generated by the git command. +[submodule ".pinterest-linters"] + path = .pinterest-linters + url = https://github.com/pinterest/arcanist-linters.git diff --git a/.pinterest-linters b/.pinterest-linters new file mode 160000 index 0000000..57a3165 --- /dev/null +++ b/.pinterest-linters @@ -0,0 +1 @@ +Subproject commit 57a316545efd54cb590d41b24e644fc6e6e7736a diff --git a/.prettierignore b/.prettierignore index c2658d7..f678363 100644 --- a/.prettierignore +++ b/.prettierignore @@ -1 +1,2 @@ node_modules/ +.pinterest-linters/ diff --git a/.yamllint b/.yamllint index 35f2277..2db4611 100644 --- a/.yamllint +++ b/.yamllint @@ -4,32 +4,22 @@ yaml-files: - '*.yml' - '.yamllint' +extends: default + +ignore-from-file: .gitignore + rules: - anchors: enable - braces: enable - brackets: enable - colons: enable - commas: enable - comments: + comments-indentation: {} + document-start: + present: true level: warning - comments-indentation: - level: warning - document-end: disable - document-start: disable - empty-lines: enable - empty-values: disable - float-values: disable - hyphens: enable - indentation: enable - key-duplicates: enable - key-ordering: disable line-length: + max: 80 level: warning new-line-at-end-of-file: level: warning - new-lines: enable - octal-values: disable quoted-strings: disable - trailing-spaces: enable truthy: level: warning + # on: included because GitHub Actions + allowed-values: ['on', 'true', 'false']