From cbfa3411b3b845750bf8dbc2d33a05ec06d732f8 Mon Sep 17 00:00:00 2001 From: Yongmin Hong Date: Tue, 18 Jun 2024 19:21:43 +0900 Subject: [PATCH] CI(GitHub Actions): fix npm-pub.yml to publish correctly Summary: Fix P185 failure. Also fix L1 (`npm pkg fix`) for (eslint|prettier)-config. Signed-off-by: Yongmin Hong Test Plan: `arc lint`, and push tag again Reviewers: O1 revi & automations, revi Reviewed By: O1 revi & automations, revi Differential Revision: https://issuetracker.revi.xyz/D358 --- .github/workflows/npm-pub.yml | 6 ++++++ npm/eslint-config/package.json | 2 +- npm/prettier-config/package.json | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/npm-pub.yml b/.github/workflows/npm-pub.yml index 55d453f..38c7b5e 100644 --- a/.github/workflows/npm-pub.yml +++ b/.github/workflows/npm-pub.yml @@ -11,6 +11,9 @@ jobs: eslint-config: name: 'Publish eslint-config to npm' runs-on: ubuntu-latest + permissions: + contents: read + id-token: write if: contains(github.ref_name, 'eslint-config@') steps: - name: 'Checkout' @@ -32,6 +35,9 @@ jobs: prettier-config: name: 'Publish prettier-config to npm' runs-on: ubuntu-latest + permissions: + contents: read + id-token: write if: contains(github.ref_name, 'prettier-config@') steps: - name: 'Checkout' diff --git a/npm/eslint-config/package.json b/npm/eslint-config/package.json index 6e6bc6a..6b509b0 100644 --- a/npm/eslint-config/package.json +++ b/npm/eslint-config/package.json @@ -23,7 +23,7 @@ ], "repository": { "type": "git", - "url": "https://github.com/revi/sandbox.git", + "url": "git+https://github.com/revi/sandbox.git", "directory": "npm/eslint-config" }, "author": { diff --git a/npm/prettier-config/package.json b/npm/prettier-config/package.json index 19e1258..eba5ba5 100644 --- a/npm/prettier-config/package.json +++ b/npm/prettier-config/package.json @@ -20,7 +20,7 @@ }, "repository": { "type": "git", - "url": "https://github.com/revi/sandbox.git", + "url": "git+https://github.com/revi/sandbox.git", "directory": "npm/prettier-config" }, "bugs": {