Commit graph

116 commits

Author SHA1 Message Date
cbfa3411b3
CI(GitHub Actions): fix npm-pub.yml to publish correctly
Summary:
Fix P185 failure.

Also fix L1 (`npm pkg fix`) for (eslint|prettier)-config.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc lint`, and push tag again

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D358
2024-06-18 19:26:34 +09:00
0b10676c4f
CI(GitHub Actions): Fix syntax if: statement
Summary:
Forgot there's contains() logic.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land`, and make a new tag and push.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D357
2024-06-18 19:19:03 +09:00
351abd6425
CI(GitHub Actions): add npm autopublishing script
Summary:
Handles (eslint|prettier)-config in one script.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land` and push a tag for testing.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D356
2024-06-18 19:08:38 +09:00
5c16c87f8d
npm(prettier-config): add prettier plugins, add rules, consolidate
Summary:
And run `npm run p:w .` for that, and add .prettierignore so `sh` plugin ignores them.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm run p:c .` and `npm publish`.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D355
2024-06-18 18:46:30 +09:00
679378baa3
CI(GitHub Actions): add codeql
Summary:
CodeQL just for... CodeQL.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land`.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D343
2024-06-17 13:06:55 +09:00
959705258e
npm(eslint-config): correct wrong peerDependency
Summary:
eslint-config-prettier should have been peerDependency not devDependency.
Correct them by moving it.

(Also do some yml cleanups.)

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm ci`.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D342
2024-06-17 12:53:55 +09:00
68f2133e9c
PhabExt(robots.txt): add more rules, ...
Summary:
setClientIDCookie none to return Response, more rules, todo:

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: deploy?

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D338
2024-06-17 12:46:53 +09:00
9afee876a5
npm(README): add shields.io badges
Summary:
Not worthy of new release though.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Browse the markdown in editor's preview mode

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D337
2024-06-17 12:46:50 +09:00
0f4b7c97e3
CI: add eslint
Summary:
Signed-off-by: Yongmin Hong <revi@omglol.email>

npm: use @revi/eslint-config

Also change eslint format, and publish `v0.0.2`.
Also prepare for eslint-config-wikimedia when they have eslint9 support.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm run eslint`.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D332
2024-06-16 15:50:44 +09:00
be3db3c067
npm(eslint-config): eslint shard config
Summary:
Yet another shared config for consolidation.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land`, `npm publish`, and install it.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D331
2024-06-16 14:49:55 +09:00
b1740bd0cd
CI(.arclint): use Pinterest Arcanist Linter
Summary:
Thanks pinterest!

Also fix some GitHub Actions error.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: run `arc lint`?

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D325
2024-06-16 14:45:56 +09:00
41b70cb468
npm(prettier-config): add README/author data, make prettier peerDependency
Summary:
Bump to 0.0.2.

For easier browsing...

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land`, and `npm publish`

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D310
2024-06-14 19:49:11 +09:00
01e6487932
npm: use shared prettier config
Summary:
Shared config testbed, yeah.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm run p:c .` should run as it is.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D305
2024-06-14 17:24:13 +09:00
8865e172f9
npm(prettier-config): add new sharable config
Summary:
Docs: https://prettier.io/docs/en/configuration#sharing-configurations

To be published @ npm and imported elsewhere.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: no test can be performed at this time; needs to be landed, published to npm, and then we can test from other tepo importing this.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D302
2024-06-14 17:18:03 +09:00
1a8f2aaccf
meta: gitattributes
Summary:
Better markdown/css diff handling and binary handling

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: not really?

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D271
2024-06-12 11:51:02 +09:00
55ce2b96ac
gitignore: add wikiploy config file
Summary:
For D22 and D229, so those doesn't need conflicting `.gitignore` entry.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `touch wmf.bot.config.mjs`, verify `git status` has no pending files to commit.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D230
2024-06-09 22:47:45 +09:00
04798b45fd
style: npm run p:w .
Summary:
Which is essentially `npx prettier --write .`

Also fix `jshint` (possible) FP, wrong chars.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm run p:w .` and verify no changes made.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D217
2024-06-09 22:11:33 +09:00
aca8c5967b
CI: new package and configs
Summary:
add following npm packages:

 - jshint
 - prettier

Add `prettier` configs and `.arclint` accordingly.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm run pcheck`, `npm run pwrite`.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D216
2024-06-08 19:04:29 +09:00
ffae464265
CI(GitHub Actions): change actions versioning
Summary:
commit hash is not my preferred solution, Just use tags.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land`?

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D194
2024-06-08 12:06:24 +09:00
fecb9204c1
gitignore: remove OS-specific entries
Summary:
There's better solution for this: `~/.gitignore`.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: No test needed.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D137
2024-06-08 12:06:22 +09:00
609068524b
CI(GitHub Actions): run builds on workflow yml file edit
Summary:
different ci config might render jobs to fail.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Verify test run after `arc land`

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D139
2024-05-26 15:03:13 +09:00
50a7eeb582
CI(GitHub Actions): fix php -l script
Summary:
Was not calling from the repo rootdir. Fix it.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land`. Wait for GitHub Actions to run.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D149
2024-05-26 15:03:11 +09:00
dependabot[bot]
b28b636f0a
Merge pull request #3 from revi/dependabot/github_actions/master/docker/metadata-action-f7b4ed12385588c3f9bc252f0a2b520d83b52d48 2024-05-23 14:51:38 +00:00
dependabot[bot]
1d28b2e49b
Merge pull request #2 from revi/dependabot/github_actions/master/docker/build-push-action-2a53c6ccda456d31fb62eedc658aae06e238b7bd 2024-05-23 14:50:36 +00:00
dependabot[bot]
2a04b984dc
Merge pull request #4 from revi/dependabot/github_actions/master/docker/login-action-70fccc794acd729b2b22dd6a326895f286447728 2024-05-23 14:46:09 +00:00
dependabot[bot]
4fe96f7469
Merge pull request #5 from revi/dependabot/npm_and_yarn/container/lighthouse-ci-server/npm_and_yarn-d4732a2d37 2024-05-23 07:37:07 +00:00
dependabot[bot]
ef42bb9254
build(deps): bump mysql2
Bumps the npm_and_yarn group with 1 update in the /container/lighthouse-ci-server directory: [mysql2](https://github.com/sidorares/node-mysql2).


Updates `mysql2` from 2.3.3 to 3.9.7
- [Release notes](https://github.com/sidorares/node-mysql2/releases)
- [Changelog](https://github.com/sidorares/node-mysql2/blob/master/Changelog.md)
- [Commits](https://github.com/sidorares/node-mysql2/compare/v2.3.3...v3.9.7)

---
updated-dependencies:
- dependency-name: mysql2
  dependency-type: direct:production
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-23 07:34:11 +00:00
dependabot[bot]
adbe151bf2
build(deps): bump docker/login-action
Bumps [docker/login-action](https://github.com/docker/login-action) from 65b78e6e13532edd9afa3aa52ac7964289d1a9c1 to 70fccc794acd729b2b22dd6a326895f286447728.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](65b78e6e13...70fccc794a)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-23 07:33:28 +00:00
dependabot[bot]
66e6752fff
build(deps): bump docker/metadata-action
Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 9ec57ed1fcdbf14dcef7dfbe97b2010124a938b7 to f7b4ed12385588c3f9bc252f0a2b520d83b52d48.
- [Release notes](https://github.com/docker/metadata-action/releases)
- [Commits](9ec57ed1fc...f7b4ed1238)

---
updated-dependencies:
- dependency-name: docker/metadata-action
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-23 07:32:12 +00:00
dependabot[bot]
f4ef37df09
build(deps): bump docker/build-push-action
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from f2a1d5e99d037542a71f64918e516c093c6f3fc4 to 2a53c6ccda456d31fb62eedc658aae06e238b7bd.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](f2a1d5e99d...2a53c6ccda)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-23 07:30:42 +00:00
b77d708548
CI(Github Actions): Remove attestation
Summary:
Not really needed, and causing build to ultimately fail.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Build again.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D136
2024-05-23 16:26:54 +09:00
eeae57a78e
Dependabot: add docker dependencies
Summary:
/shrug

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Wait for Monday for dependabot to trigger.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D135
2024-05-23 16:22:53 +09:00
5f921ddcf8
CI (GitHub Actions): actions/checkout
Summary:
I am stupid enough, yeah

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Watch the GitHub Actions run again

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D134
2024-05-23 16:22:51 +09:00
f2ff297047
CI (GitHub Actions): Fix build error
Summary:
Working space errors.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: merge, watch GitHub Actions runs.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D133
2024-05-23 16:16:34 +09:00
cdf70a8ee2
container: build and publish containers
Summary:
Cheap docker hub alt :P

Dockerfile from [googlechrome/lighthouse-ci](https://github.com/GoogleChrome/lighthouse-ci/tree/main/docs/recipes/docker-server)

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Check GitHub Actions runs?

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D132
2024-05-23 16:12:11 +09:00
bf5c8a9281
Robots.txt: f off PetalBot
Summary:
Is on .xyz/robots.txt blacklist. add it here as well.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Deploy

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D125
2024-05-23 04:20:04 +09:00
86751ae2ea
replace time.php into redirect
Summary:
D110 made this obsolete; redirect to `https://revi.xyz/time`.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: k.revi.xyz/time.php > 302 revi.xyz/time

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D119
2024-05-21 15:44:48 +09:00
7c443bcca5
time.php: add note about time notation
Summary:
Clarify it is 24h notation, and people should expect 0-12h to take it as such.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: load the diff, and view from firefox.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D87
2024-05-14 21:32:58 +00:00
08863ae041 time.php: add DOCTYPE
Summary:
`<!DOCTYPE html>`, a good thing to do ™️.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: load the page in browser.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D82
2024-05-13 20:02:48 +09:00
d75d8cf807
.arclint: more rules, exclusions
Summary:
Probably standard changes (tm) at this point.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc lint`

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D79
2024-05-12 19:02:50 +09:00
467eb9b2d1
robotstxt: just use *
Summary:
Fixes T138. Seems like Google doesn't care.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Try http://go/google/search w/ updated robots.txt entries

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Maniphest Tasks: T138

Differential Revision: https://issuetracker.revi.xyz/D75
2024-05-11 17:29:11 +09:00
a257d3ccb4
robots.txt: shorten some links
Summary:
Less size /shrug

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: try visiting URLs to test redirection

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D66
2024-05-10 18:19:11 +09:00
1fc290faa5
wikiassets: rename global.(css|js) to nonwmf.(css|js)
Summary:
Plan is to also migrate go/wiki/m/User:-revi/global.(css|js) to here as well.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Load from jsdelivr.

Reviewers: #acl_sudoers, #blessed_reviewers, revi

Reviewed By: #acl_sudoers, #blessed_reviewers, revi

Differential Revision: https://issuetracker.revi.xyz/D21
2024-05-04 17:47:11 +09:00
1df5ac5ff6
wikiassets: Add repo
Summary:
Just use jsdelivr

Bug: Fixes T130
Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Test after merge

Reviewers: #acl_sudoers, #blessed_reviewers, revi

Reviewed By: #acl_sudoers, #blessed_reviewers, revi

Maniphest Tasks: T130

Differential Revision: https://issuetracker.revi.xyz/D19
2024-05-04 17:41:49 +09:00
d45c16bde1
meta: arclint: add few more rules
Summary:
I probably want few more rules (ie. csslint)

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc lint`

Reviewers: #acl_sudoers, #blessed_reviewers, revi

Reviewed By: #acl_sudoers, #blessed_reviewers, revi

Differential Revision: https://issuetracker.revi.xyz/D20
2024-05-04 17:34:01 +09:00
c628542223
Revert "RobotsTxt: specify more verbose classes"
Summary:
This reverts commit 88946a7fe2.

PHP Fatal error:  Cannot override final method PhabricatorRobotsController::processRequest() in /var/www/phorge/phorge/src/extensions/PhabricatorCustomRobotsTxtController.php on line 13

Fatal error: Cannot override final method PhabricatorRobotsController::processRequest() in /var/www/phorge/phorge/src/extensions/PhabricatorCustomRobotsTxtController.php on line 13

Signed-off-by: Yongmin Hong <revi@omglol.email>

Reviewers: #acl_sudoers, #blessed_reviewers, revi

Reviewed By: #acl_sudoers, #blessed_reviewers, revi

Differential Revision: https://issuetracker.revi.xyz/D10
2024-05-02 19:56:13 +09:00
88946a7fe2
RobotsTxt: specify more verbose classes
Summary:
Using PhabricatorRobotsController overwrites robots.txt for blogs, URL shortener, and CDN domains. Using [PhabricatorRobotsPlatformController](https://we.phorge.it/book/dev/class/PhabricatorRobotsPlatformController/) should fix it.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Reload personal-phorge.revicdn.net/robots.txt and it is not verbatim copy of issuetracker.revi.xyz/robots.txt

Reviewers: #acl_sudoers, #blessed_reviewers, revi

Reviewed By: #acl_sudoers, #blessed_reviewers, revi

Differential Revision: https://issuetracker.revi.xyz/D9
2024-05-02 19:48:19 +09:00
0e1656da0c
meta: various changes
Summary:
Submitting three changes at once for lazyness:

meta: config cleanups

  Add editorconfig, gitignore, and conform to them.

RobotsTxt: add differential rule and conform to the editorconfig

time.php: add metadata, editorconfig conformance

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `code .` and edit files. for php files, deploy.

Reviewers: #acl_sudoers, #blessed_reviewers, revi

Reviewed By: #acl_sudoers, #blessed_reviewers, revi

Differential Revision: https://issuetracker.revi.xyz/D8
2024-05-02 19:30:12 +09:00
d2f7806542
meta: Add .arcconfig
Summary: Either Phab differential or Gerrit (to be installed) but not sure what to use.

Test Plan: `arc patch`, verify lint works and connects to this instance.

Reviewers: #acl_sudoers, #blessed_reviewers, revi

Reviewed By: #acl_sudoers, #blessed_reviewers, revi

Differential Revision: https://issuetracker.revi.xyz/D7
2024-05-02 18:28:21 +09:00
893232347d
Fix html
Forgot this...

Bug: N/A
Signed-off-by: Yongmin Hong <revi@omglol.email>
2024-04-30 18:28:51 +09:00