Summary:
Forgot there's contains() logic.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `arc land`, and make a new tag and push.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D357
Summary:
Handles (eslint|prettier)-config in one script.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `arc land` and push a tag for testing.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D356
Summary:
And run `npm run p:w .` for that, and add .prettierignore so `sh` plugin ignores them.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `npm run p:c .` and `npm publish`.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D355
Summary:
eslint-config-prettier should have been peerDependency not devDependency.
Correct them by moving it.
(Also do some yml cleanups.)
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `npm ci`.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D342
Summary:
commit hash is not my preferred solution, Just use tags.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `arc land`?
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D194
Summary:
different ci config might render jobs to fail.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: Verify test run after `arc land`
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D139
Summary:
Was not calling from the repo rootdir. Fix it.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `arc land`. Wait for GitHub Actions to run.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D149
Summary:
I am stupid enough, yeah
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: Watch the GitHub Actions run again
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D134
Summary:
This reverts commit 88946a7fe2.
PHP Fatal error: Cannot override final method PhabricatorRobotsController::processRequest() in /var/www/phorge/phorge/src/extensions/PhabricatorCustomRobotsTxtController.php on line 13
Fatal error: Cannot override final method PhabricatorRobotsController::processRequest() in /var/www/phorge/phorge/src/extensions/PhabricatorCustomRobotsTxtController.php on line 13
Signed-off-by: Yongmin Hong <revi@omglol.email>
Reviewers: #acl_sudoers, #blessed_reviewers, revi
Reviewed By: #acl_sudoers, #blessed_reviewers, revi
Differential Revision: https://issuetracker.revi.xyz/D10
Summary:
Using PhabricatorRobotsController overwrites robots.txt for blogs, URL shortener, and CDN domains. Using [PhabricatorRobotsPlatformController](https://we.phorge.it/book/dev/class/PhabricatorRobotsPlatformController/) should fix it.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: Reload personal-phorge.revicdn.net/robots.txt and it is not verbatim copy of issuetracker.revi.xyz/robots.txt
Reviewers: #acl_sudoers, #blessed_reviewers, revi
Reviewed By: #acl_sudoers, #blessed_reviewers, revi
Differential Revision: https://issuetracker.revi.xyz/D9
