Commit graph

7 commits

Author SHA1 Message Date
959705258e
npm(eslint-config): correct wrong peerDependency
Summary:
eslint-config-prettier should have been peerDependency not devDependency.
Correct them by moving it.

(Also do some yml cleanups.)

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm ci`.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D342
2024-06-17 12:53:55 +09:00
b1740bd0cd
CI(.arclint): use Pinterest Arcanist Linter
Summary:
Thanks pinterest!

Also fix some GitHub Actions error.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: run `arc lint`?

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D325
2024-06-16 14:45:56 +09:00
04798b45fd
style: npm run p:w .
Summary:
Which is essentially `npx prettier --write .`

Also fix `jshint` (possible) FP, wrong chars.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm run p:w .` and verify no changes made.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D217
2024-06-09 22:11:33 +09:00
50a7eeb582
CI(GitHub Actions): fix php -l script
Summary:
Was not calling from the repo rootdir. Fix it.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land`. Wait for GitHub Actions to run.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D149
2024-05-26 15:03:11 +09:00
c628542223
Revert "RobotsTxt: specify more verbose classes"
Summary:
This reverts commit 88946a7fe2.

PHP Fatal error:  Cannot override final method PhabricatorRobotsController::processRequest() in /var/www/phorge/phorge/src/extensions/PhabricatorCustomRobotsTxtController.php on line 13

Fatal error: Cannot override final method PhabricatorRobotsController::processRequest() in /var/www/phorge/phorge/src/extensions/PhabricatorCustomRobotsTxtController.php on line 13

Signed-off-by: Yongmin Hong <revi@omglol.email>

Reviewers: #acl_sudoers, #blessed_reviewers, revi

Reviewed By: #acl_sudoers, #blessed_reviewers, revi

Differential Revision: https://issuetracker.revi.xyz/D10
2024-05-02 19:56:13 +09:00
88946a7fe2
RobotsTxt: specify more verbose classes
Summary:
Using PhabricatorRobotsController overwrites robots.txt for blogs, URL shortener, and CDN domains. Using [PhabricatorRobotsPlatformController](https://we.phorge.it/book/dev/class/PhabricatorRobotsPlatformController/) should fix it.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Reload personal-phorge.revicdn.net/robots.txt and it is not verbatim copy of issuetracker.revi.xyz/robots.txt

Reviewers: #acl_sudoers, #blessed_reviewers, revi

Reviewed By: #acl_sudoers, #blessed_reviewers, revi

Differential Revision: https://issuetracker.revi.xyz/D9
2024-05-02 19:48:19 +09:00
383155f51d
actions: php quick syntax check
cf. https://we.phorge.it/book/phorge/article/configuring_preamble/

Bug: N/A
Signed-off-by: Yongmin Hong <revi@omglol.email>
2024-04-20 18:04:53 +09:00