Summary:
Forgot there's contains() logic.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `arc land`, and make a new tag and push.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D357
Summary:
Handles (eslint|prettier)-config in one script.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `arc land` and push a tag for testing.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D356
Summary:
And run `npm run p:w .` for that, and add .prettierignore so `sh` plugin ignores them.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `npm run p:c .` and `npm publish`.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D355
Summary:
eslint-config-prettier should have been peerDependency not devDependency.
Correct them by moving it.
(Also do some yml cleanups.)
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `npm ci`.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D342
Summary:
Signed-off-by: Yongmin Hong <revi@omglol.email>
npm: use @revi/eslint-config
Also change eslint format, and publish `v0.0.2`.
Also prepare for eslint-config-wikimedia when they have eslint9 support.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `npm run eslint`.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D332
Summary:
Shared config testbed, yeah.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `npm run p:c .` should run as it is.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D305
Summary:
Docs: https://prettier.io/docs/en/configuration#sharing-configurations
To be published @ npm and imported elsewhere.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: no test can be performed at this time; needs to be landed, published to npm, and then we can test from other tepo importing this.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D302
Summary:
For D22 and D229, so those doesn't need conflicting `.gitignore` entry.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `touch wmf.bot.config.mjs`, verify `git status` has no pending files to commit.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D230
Summary:
commit hash is not my preferred solution, Just use tags.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `arc land`?
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D194
Summary:
different ci config might render jobs to fail.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: Verify test run after `arc land`
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D139
Summary:
Was not calling from the repo rootdir. Fix it.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `arc land`. Wait for GitHub Actions to run.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D149
Summary:
I am stupid enough, yeah
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: Watch the GitHub Actions run again
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D134
Summary:
Is on .xyz/robots.txt blacklist. add it here as well.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: Deploy
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D125
Summary:
Clarify it is 24h notation, and people should expect 0-12h to take it as such.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: load the diff, and view from firefox.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D87
Summary:
`<!DOCTYPE html>`, a good thing to do ™️.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: load the page in browser.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D82
Summary:
Plan is to also migrate go/wiki/m/User:-revi/global.(css|js) to here as well.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: Load from jsdelivr.
Reviewers: #acl_sudoers, #blessed_reviewers, revi
Reviewed By: #acl_sudoers, #blessed_reviewers, revi
Differential Revision: https://issuetracker.revi.xyz/D21
Summary:
This reverts commit 88946a7fe2.
PHP Fatal error: Cannot override final method PhabricatorRobotsController::processRequest() in /var/www/phorge/phorge/src/extensions/PhabricatorCustomRobotsTxtController.php on line 13
Fatal error: Cannot override final method PhabricatorRobotsController::processRequest() in /var/www/phorge/phorge/src/extensions/PhabricatorCustomRobotsTxtController.php on line 13
Signed-off-by: Yongmin Hong <revi@omglol.email>
Reviewers: #acl_sudoers, #blessed_reviewers, revi
Reviewed By: #acl_sudoers, #blessed_reviewers, revi
Differential Revision: https://issuetracker.revi.xyz/D10
Summary:
Using PhabricatorRobotsController overwrites robots.txt for blogs, URL shortener, and CDN domains. Using [PhabricatorRobotsPlatformController](https://we.phorge.it/book/dev/class/PhabricatorRobotsPlatformController/) should fix it.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: Reload personal-phorge.revicdn.net/robots.txt and it is not verbatim copy of issuetracker.revi.xyz/robots.txt
Reviewers: #acl_sudoers, #blessed_reviewers, revi
Reviewed By: #acl_sudoers, #blessed_reviewers, revi
Differential Revision: https://issuetracker.revi.xyz/D9
Summary:
Submitting three changes at once for lazyness:
meta: config cleanups
Add editorconfig, gitignore, and conform to them.
RobotsTxt: add differential rule and conform to the editorconfig
time.php: add metadata, editorconfig conformance
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `code .` and edit files. for php files, deploy.
Reviewers: #acl_sudoers, #blessed_reviewers, revi
Reviewed By: #acl_sudoers, #blessed_reviewers, revi
Differential Revision: https://issuetracker.revi.xyz/D8
Summary: Either Phab differential or Gerrit (to be installed) but not sure what to use.
Test Plan: `arc patch`, verify lint works and connects to this instance.
Reviewers: #acl_sudoers, #blessed_reviewers, revi
Reviewed By: #acl_sudoers, #blessed_reviewers, revi
Differential Revision: https://issuetracker.revi.xyz/D7
