N-archive/citra
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
9460 commits 1 branch 0 tags 134 MiB
Commit graph

9460 commits

This branch
This branch
All branches
Author SHA1 Message Date
Lioncash
6ed4431d8b file_util: Early-exit in WriteArray and ReadArray if specified lengths are zero 
It's undefined behavior to pass a null pointer to std::fread and
std::fwrite, even if the length passed in is zero, so we must perform
the precondition checking ourselves.

A common case where this can occur is when passing in the data of an
empty std::vector and size, as an empty vector will typically have a
null internal buffer.

While we're at it, we can move the implementation out of line and add
debug checks against passing in nullptr to std::fread and std::fwrite.
 2020-05-11 01:58:13 +02:00
Vitor Kiguchi
01b9302a28 game_list: cleanup and clang format in AddPermDirPopup 2020-05-10 13:45:43 -03:00
Vitor Kiguchi
fbf24e3ca4 game_list: fix folder reordering 2020-05-09 23:44:41 -03:00
Vitor Kiguchi
950c032837 change gameListDir to hold an index instead of a raw pointer 2020-05-09 23:36:40 -03:00
Ben
8d27b0714d
Merge pull request #5335 from lioncash/nullopt 
gl_shader_manager: Make use of std::nullopt where applicable
 2020-05-09 12:36:23 +02:00
Ben
4892d37309
Merge pull request #5336 from lioncash/constexpr 
gl_rasterizer_cache: Make use of if constexpr in MortonCopyTile()
 2020-05-09 12:36:04 +02:00
Ben
007fb63e47
Merge pull request #5230 from B3n30/circumvent_apple_intel_hw_shader_issue 
Add flag to disable seperable shaders for osx Intel GPUs.
 2020-05-09 12:34:21 +02:00
Ben
8a69172570
Merge pull request #5231 from hamish-milne/fix-address-arbiter-serialization 
Fix Address Arbiter serialization
 2020-05-09 12:33:35 +02:00
Ben
96ebd53466
Merge pull request #5264 from lioncash/gen 
gl_shader_gen: Make use of fmt where applicable
 2020-05-09 12:28:57 +02:00
Ben
e959d44f00
Merge pull request #5262 from lioncash/fmt 
gl_shader_decompiler: Make use of fmt with the decompiler
 2020-05-09 12:28:34 +02:00
Lioncash
cd201cd60f gl_shader_gen: Make use of fmt where applicable 
Avoids string churn and makes it significantly easier to read the shader
template strings that are being used as the basis for formatting.
 2020-05-08 14:50:48 -04:00
z87
e792c3d90c citra_qt: remove incorrect style in the Dark theme 
Property "overflow" isn't documented, and it makes Qt complain about an
unknown property in the terminal.
 2020-05-08 20:04:05 +03:00
z87
09cba69b48 citra_qt: improve touchscreen mapping UI 2020-05-08 20:04:05 +03:00
Lioncash
38c8fecb81 gl_rasterizer_cache: Make use of if constexpr in MortonCopyTile() 
A trivial change that allows compilers to more rigorously optimize out
code blocks that will never be executed in some scenarios.
 2020-05-04 23:08:53 -04:00
Lioncash
f2a7fe05c3 gl_shader_manager: Make use of std::nullopt where applicable 
Prevents the internal buffer in the std::optional from being zeroed out
unnecessarily and instead sets the validity byte only in some
implementations.

While we're at it, we can make use of std::move to eliminate unnecessary
heap reallocations from occurring.
 2020-05-04 23:00:11 -04:00
Lioncash
016d43df98 gl_shader_decompiler: Make use of fmt with the decompiler 
Allows us to avoid even more string churn by allowing the AddLine
function to make use of fmt formatting so the string is formatted all at
once instead of concatenating multiple strings.

This is similar to how yuzu's decompiler works, which I've made function
the same way in the past.
 2020-05-04 22:40:33 -04:00
Lioncash
ba2ae9616a fs_user: std::move vectors where applicable 
Allows removing some allocation churn in some locations by moving
std::vectors into Path where applicable.
 2020-05-04 12:07:57 -04:00
Dragios
841522f59c Try to fix executable path generated in CI 2020-05-04 22:35:20 +08:00
z87
41facaece3 input_common: add TouchFromButtonDevice 2020-05-04 13:51:37 +03:00
Vitor K
36809b2e2e
Small fixes to "Option to hide mouse on inactivity" (#5280) 
* Menubar: fix mouse tracking bug

* citra_qt: Fix copy/paste error
 2020-05-04 12:33:02 +02:00
Mat M
e9819b61a6
service: Mark variables as [[maybe_unused]] where applicable (#5318) 
Quite a few service functions are stubbed but still pop all their
arguments, which can lead to unused variable warnings.

We can mark the unused arguments with [[maybe_unused]] to silence these
warnings until a full implementation of these functions are made.
 2020-05-04 12:22:33 +02:00
Mat M
6e48149ee1
fs/archive: Make use of std::make_shared where applicable (#5319) 
Allows implementations to allocate the object and the shared_ptr control
block in one allocation instead of needing to do two separate
allocations.

Also looks much nicer to the reader.
 2020-05-04 12:22:13 +02:00
Mat M
79536ddb11
service/cfg: Convert file-scope std::vector to std::array (#5320) 
Same behavior, but without a static runtime constructor that needs to
run at program start.
 2020-05-04 12:21:56 +02:00
Mat M
30414eeb4b
service/cfg: Make GenerateConsoleUniqueId() return a pair (#5321) 
Same behavior, but allows the use of structured bindings.
 2020-05-04 12:21:43 +02:00
Valentin Vanelslande
41abdb505c
common/logging/log: Add LLE in Audio_DSP comment (#5327) 
@wwylele forgot to add it in https://github.com/citra-emu/citra/pull/4490.
 2020-05-04 12:20:56 +02:00
Ben
2874401703
cfg-savegame: add DebugMode block (#5330) 2020-05-04 12:19:44 +02:00
B3n30
ed48f8accf clang-format fix 2020-05-04 12:14:40 +02:00
zhaobot
7f1a87574b
Update translations (2020-05-01) (#5289) 
* Update translations (2020-05-01)

* Update dist/languages/zh_CN.ts

Co-authored-by: rcyggdra <rcyggdra@gmail.com>

Co-authored-by: The Citra Community <noreply-fake@community.citra-emu.org>
Co-authored-by: Pengfei Zhu <zhupf321@gmail.com>
Co-authored-by: rcyggdra <rcyggdra@gmail.com>
 2020-05-04 11:31:49 +02:00
Pengfei Zhu
60669a7dd8
swkbd: Fix a bug where clicking Cancel hangs the game (#5294) 
* swkbd: Fix a bug where clicking Cancel hangs the game

The text is validated in `Finalize`. If the validation fails, an error is returned and the applet is not actually finalized. This can result in hangs.

This is usually not a problem as the frontend is expected to validate the text passed to `Finalize`. However, when the user clicked on `Cancel`, the text is ignored and the frontend won't do any validation. Therefore, we should skip the validation here as well.

Also fixed a potential data race. All these functions should now be called on the same thread

* Address review comments

Renamed the fields
Remove close button
 2020-05-04 11:31:17 +02:00
Dragios
bf1166d0ee Correct output paths for executable binaries 2020-05-02 22:24:28 +08:00
MerryMage
1f375f2511 travis: Compile on macOS 10.13 with more up to date compiler 2020-05-02 08:50:42 +01:00
Pengfei Zhu
41bff0e3b7
Merge pull request #5316 from lioncash/init 
core: Resolve -Wreorder warnings
 2020-05-02 15:42:31 +08:00
Pengfei Zhu
eb996f046d
Merge pull request #5315 from lioncash/undef 
soc_u: Prevent undefined behavior with CTRPollFD
 2020-05-02 15:41:59 +08:00
Lioncash
563a540dfd core: Resolve -Wreorder warnings 
Ensures the initialization order matches the actual order that the class
member variables will be initialized in.
 2020-05-01 23:32:46 -04:00
Lioncash
a32ad7f1f2 soc_u: Prevent undefined behavior with CTRPollFD 
This class is memcpy-ed and memcpy has the requirement that data passed
to it must be trivially copyable, otherwise the behavior is undefined.

This is trivial to resolve as BitField was made trivially copyable a
while ago, so this explicit copy assignment operator isn't necessary.
 2020-05-01 22:30:10 -04:00
Pengfei Zhu
2476532f21
Merge pull request #5302 from lioncash/teak 
CMakeLists: Specify EXCLUDE_FROM_ALL for teakra
 2020-05-02 10:21:18 +08:00
Pengfei Zhu
e212dc3a1f
Merge pull request #5297 from lioncash/missing 
gl_rasterizer: Amend missing return value in branch in SetupGeometryShader()
 2020-05-02 08:07:49 +08:00
Pengfei Zhu
70a43be714
Merge pull request #5306 from lioncash/view2 
file-sys: Make use of std::string_view where applicable
 2020-05-02 08:07:10 +08:00
Pengfei Zhu
8e7abecf7e
Merge pull request #5307 from lioncash/guard 
file_sys/seed_db: Add missing include guard
 2020-05-02 08:04:58 +08:00
Pengfei Zhu
5a008a74fa
Merge pull request #5304 from lioncash/layered 
layered_fs: Mark functions as static where applicable
 2020-05-02 08:02:35 +08:00
Pengfei Zhu
6907568034
Merge pull request #5309 from lioncash/dtor 
applets: Make destructors virtual where applicable
 2020-05-02 08:02:14 +08:00
Pengfei Zhu
59984df603
Merge pull request #5308 from lioncash/rsa 
core/hw/rsa: Minor cleanup
 2020-05-02 08:01:58 +08:00
David Marcec
5832857bc0 externals: Update cubeb to 616d773 
Support for 6 audio channels

Co-Authored-By: David <ognik5377@users.noreply.github.com>
 2020-05-01 22:15:50 +02:00
Pengfei Zhu
4d7487bd34
Merge pull request #5298 from lioncash/unused 
gl_rasterizer: Silence various compilation warnings
 2020-05-01 23:34:36 +08:00
Pengfei Zhu
037c857bd6
Merge pull request #5303 from lioncash/namespace 
service/ir: Remove erroneous forward declaration
 2020-05-01 23:04:01 +08:00
Pengfei Zhu
017f0c469e
Merge pull request #5301 from lioncash/chunk 
common: Remove chunk_file.h
 2020-05-01 23:02:47 +08:00
Pengfei Zhu
6a0636d631
Merge pull request #5296 from lioncash/flatten 
gl_rasterizer_cache: Flatten LoadCustomTexture()
 2020-05-01 23:01:47 +08:00
Pengfei Zhu
2eacb11c53
Merge pull request #5292 from lioncash/alloc 
gl_shader_manager: Eliminate variable shadowing
 2020-05-01 22:57:55 +08:00
Pengfei Zhu
1bb9a71a01
Merge pull request #5291 from lioncash/trunc 
renderer_opengl: Resolve compiler truncation warnings
 2020-05-01 22:56:46 +08:00
Lioncash
89eeb64854 applets/swkbd: Make destructor virtual 
Prevents undefined behavior when destroying a derived class through a
base class pointer.
 2020-05-01 10:44:31 -04:00