N-archive/pineapple-src
1
0
Fork 0
Code Issues 5 Pull requests 2 Projects Releases Packages Wiki Activity

Remove old files from SDL external #50

Merged
sbruder merged 1 commit from remove-deleted-sdl-files into main 2022-01-23 12:52:05 +01:00
Conversation 2 Commits 1 Files changed 86 -18934
sbruder commented 2022-01-22 11:29:39 +01:00 (Migrated from github.com)
Copy link

They were already removed in SDL upstream but the update mechanism did not remove them in this repository.

For example, upstream SDL renamed README.txt to README.md in 3c78c211d57de4e9d953bf71d49d2ee313bbff34, so README.txt should have been removed. However, the relevant commit (5dbb928ff2) only adds README.md and leaves deleted files in the repository.

Some of the old files were causing build failures when the SDL external was used (see #45, which only received a workaround in #46; this PR should be the actual fix for the problem).

A fix should probably also be incorporated into the mechanism that updates the repository, which is probably missing a way to delete files that were deleted in a newer version (like rsync’s --delete). However, I didn’t find such a tool and don’t know if it is public, so I couldn’t fix it.

They were already removed in SDL upstream but the update mechanism did not remove them in this repository. For example, upstream SDL renamed `README.txt` to `README.md` in `3c78c211d57de4e9d953bf71d49d2ee313bbff34`, so `README.txt` should have been removed. However, the relevant commit (5dbb928ff237591abfd4bd32871624878902926e) only adds `README.md` and leaves deleted files in the repository. Some of the old files were causing build failures when the SDL external was used (see #45, which only received a workaround in #46; this PR should be the actual fix for the problem). A fix should probably also be incorporated into the mechanism that updates the repository, which is probably missing a way to delete files that were deleted in a newer version (like rsync’s `--delete`). However, I didn’t find such a tool and don’t know if it is public, so I couldn’t fix it.
MGThePro commented 2022-01-23 12:51:59 +01:00 (Migrated from github.com)
Copy link

good catch, I completely forgot about files that get removed upstream. Will have to look into a proper solution for that later

good catch, I completely forgot about files that get removed upstream. Will have to look into a proper solution for that later
👍 1
MGThePro commented 2022-01-23 13:12:31 +01:00 (Migrated from github.com)
Copy link

Don't worry about the failing CI, that seems due to some stuff related to linuxdeployqt, not this change

Don't worry about the failing CI, that seems due to some stuff related to linuxdeployqt, not this change
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: N-archive/pineapple-src#50
No description provided.
Delete branch "remove-deleted-sdl-files"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?