Pre-merge checks

The pre-merge checks for the LLVM project are a continuous integration (CI) workflow. The workflow checks the patches the developers upload to the LLVM Phabricator instance. Phabricator is the code review tool in the LLVM project. The workflow checks the patches before a user merges them the master branch - thus the term pre-merge testing. When a user uploads a patch to the LLVM Phabricator, Phabricator triggers the checks and then displays the results.

The checks comprise of these steps:

Checkout of the git repository
Apply the patch -- arc patch
Run Cmake -- see run_cmake.sh for details
Build the binaries -- ninja all
Run the test suite -- ninja check-all
Run clang-format and clang-tidy on the diff.

The checks are executed on one platform (Debian Testing on amd64 with the clang-8 tool chain) at the moment. We're in the process of adding builds and Test for Windows (amd64, Visual Studio 2017). The plan is to add more platforms, in the future.

The CI system checks the patches before a user merges them to the master branch. This way bugs in a patch are contained during the code review stage and do not pollute the master branch. The more bugs the CI system can catch during the code review phase, the more stable and bug-free the master branch will become.

Beta testing

The pre-merge checks are in the public beta testing phase right now. During the beta testing phase we want so see if the checks work as intended and to get more feedback from the users.

If you find any problems please raise an issue on github.

To sign up for the pre-merge beta testing, please add yourself to the "pre-merge beta testing" project on Phabricator (H511).

The checks are enabled for all changes to clang-tools-extra/clangd (H527) and mlir(H552).

Requirements

The builds are only triggered if the Revision in Phabricator is created/updated via arc diff. If you update a Revision via the Web UI it will not trigger a build.

To get a patch on Phabricator tested - once you are signed up - the build server must be able to apply the patch to the checked out git repository. If you want to get your patch tested, please make sure that that either:

You set a git hash as sourceControlBaseRevision in Phabricator which is available on the github repository,
or you define the dependencies of your patch in Phabricator,
or your patch can be applied to the master branch.

Only then can the build server apply the patch locally and run the builds and tests.

Integration in Phabricator

Once you're signed up, Phabricator will automatically trigger a build for every new patch you upload or every existing patch you modify. Phabricator shows the build results at the top of the entry:

Bot will compile and run tests, run clang-format and clang-tidy on lines changed.

If a unit test failed, this is shown below the build status. You can also expand the unit test to see the details:

After every build the build server will comment on your latest patch, so that you can also see the results for previous changes. The comment also contains a link to the log files:

The build logs are stored for 90 days and automatically deleted after that.

You can also trigger a build manually by using the "Run Plan Manually" link on the Harbormaster page and entering a revision ID in the pop-up window.

Reporting issues

If you notice any bugs, please create a new issue.

Contributing

We're happy to get help on improving the infrastructure and the workflows. If you're interested please contact Christian Kühnel.

4.2 KiB Raw Permalink Blame History