revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-01-03 19:31:01 +01:00
Code Issues Releases Wiki Activity

Minor tweaks for XHPAST config

Browse source 
Summary: Ref T2039. The type specs are right in theory but not quite correct in practice, since we pass strings in rather than objects.

Test Plan: While tweaking `phabricator/`, adjusted these to get desirable results.

Reviewers: btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T2039

Differential Revision: https://secure.phabricator.com/D9071
This commit is contained in:
epriestley 2014-05-12 05:06:14 -07:00
parent 7bbafe91d2
commit 0583b39bb0
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/lint/linter/ArcanistXHPASTLinter.php
View file

@ -147,12 +147,16 @@ final class ArcanistXHPASTLinter extends ArcanistBaseXHPASTLinter {
public function getLinterConfigurationOptions() { public function getLinterConfigurationOptions() {
return parent::getLinterConfigurationOptions() + array( return parent::getLinterConfigurationOptions() + array(
'xhpast.naminghook' => array( 'xhpast.naminghook' => array(
'type' => 'optional ArcanistXHPASTLintNamingHook', 'type' => 'optional string',
'help' => pht(''), 'help' => pht(
'Name of a concrete subclass of ArcanistXHPASTLintNamingHook which '.
'enforces more granular naming convention rules for symbols.'),
), ),
'xhpast.switchhook' => array( 'xhpast.switchhook' => array(
'type' => 'optional ArcanistXHPASTLintSwitchHook', 'type' => 'optional string',
'help' => pht(''), 'help' => pht(
'Name of a concrete subclass of ArcanistXHPASTLintSwitchHook which '.
'tunes the analysis of switch() statements for this linter.'),
), ),
); );
} }