revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-08 16:02:39 +01:00
Code Issues Releases Wiki Activity

Make exception reporting from arc be in red

Browse source 
Summary:
Many other status updates (such as "Builds passed!") show up
in bright background colors, making them more salient than a final
fatal "Exception".

Make exception reporting be just as colorful, so it stands out.

Test Plan:
Added an explicit `throw new Exception("!!!")` and saw it
in red.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D17748
This commit is contained in:
Alex Vandiver 2017-04-20 14:50:03 -07:00
parent a59cfca5f1
commit 146693307f
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
scripts/arcanist.php
View file

@ -422,7 +422,8 @@ try {
} }
if (!$is_usage) { if (!$is_usage) {
fwrite(STDERR, phutil_console_format("**%s**\n", pht('Exception'))); fwrite(STDERR, phutil_console_format(
"<bg:red>** %s **</bg>\n", pht('Exception')));
while ($ex) { while ($ex) {
fwrite(STDERR, $ex->getMessage()."\n"); fwrite(STDERR, $ex->getMessage()."\n");