mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-12-23 05:50:54 +01:00
Improve 'arc' error message when failing to load a library
Summary: display better message about the .arcconfig. The message will be something like this now: Usage Exception: Failed to load library "phabricator" at location "srcaaaaa/". Please check the "phutil_libraries" setting in your .arcconfig file. Refer to page http://phabricator.com/docs/arcanist/article/Setting_Up_.arcconfig.html for more info. Test Plan: modify the .arcconfig file to test it. Also make sure it works for correct settings. Reviewed By: epriestley Reviewers: epriestley CC: jungejason, epriestley Differential Revision: 99
This commit is contained in:
parent
76c45a74f3
commit
1dd69bdbee
1 changed files with 12 additions and 1 deletions
|
@ -89,7 +89,18 @@ try {
|
|||
if (Filesystem::pathExists($resolved_location)) {
|
||||
$location = $resolved_location;
|
||||
}
|
||||
phutil_load_library($location);
|
||||
try {
|
||||
phutil_load_library($location);
|
||||
} catch (PhutilBootloaderException $ex) {
|
||||
$error_msg = sprintf(
|
||||
'Failed to load library "%s" at location "%s". Please check the '.
|
||||
'"phutil_libraries" setting in your .arcconfig file. Refer to page '.
|
||||
'http://phabricator.com/docs/arcanist/article/'.
|
||||
'Setting_Up_.arcconfig.html for more info.',
|
||||
$name,
|
||||
$location);
|
||||
throw new ArcanistUsageException($error_msg);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue