revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
Code Issues Releases Wiki Activity

Improve 'arc' error message when failing to load a library

Browse source 
Summary:
display better message about the .arcconfig. The message will
be something like this now:
  Usage Exception: Failed to load library "phabricator" at location
  "srcaaaaa/". Please check the "phutil_libraries" setting in your
  .arcconfig file. Refer to page
  http://phabricator.com/docs/arcanist/article/Setting_Up_.arcconfig.html
  for more info.

Test Plan:
modify the .arcconfig file to test it. Also make sure it
works for correct settings.

Reviewed By: epriestley
Reviewers: epriestley
CC: jungejason, epriestley
Differential Revision: 99
This commit is contained in:
jungejason 2011-04-04 16:26:46 -07:00
parent 76c45a74f3
commit 1dd69bdbee
1 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
scripts/arcanist.php
View file

@ -89,7 +89,18 @@ try {
if (Filesystem::pathExists($resolved_location)) { if (Filesystem::pathExists($resolved_location)) {
$location = $resolved_location; $location = $resolved_location;
} }
try {
phutil_load_library($location); phutil_load_library($location);
} catch (PhutilBootloaderException $ex) {
$error_msg = sprintf(
'Failed to load library "%s" at location "%s". Please check the '.
'"phutil_libraries" setting in your .arcconfig file. Refer to page '.
'http://phabricator.com/docs/arcanist/article/'.
'Setting_Up_.arcconfig.html for more info.',
$name,
$location);
throw new ArcanistUsageException($error_msg);
}
} }
} }