Change the default value for ArcanistExternalLinter::shouldExpectCommandErrors

Summary: It is more common for linters to exit with a non-zero status than it is for linters to return with a zero exit status, Really this function serves very little purposes, it simply determines whether or not to throw an exception if a non-zero status is returned by the external linter.

Test Plan: `arc unit`

Reviewers: chad, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11322

src/lint/linter/ArcanistCSSLintLinter.php

@@ -58,10 +58,6 @@ final class ArcanistCSSLintLinter extends ArcanistExternalLinter {
       'npm install -g csslint');
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   protected function parseLinterOutput($path, $err, $stdout, $stderr) {
     $report_dom = new DOMDocument();
     $ok = @$report_dom->loadXML($stdout);

src/lint/linter/ArcanistClosureLinter.php

@@ -37,10 +37,6 @@ final class ArcanistClosureLinter extends ArcanistExternalLinter {
       'files/closure_linter-latest.tar.gz');
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   public function supportsReadDataFromStdin() {
     return false;
   }

src/lint/linter/ArcanistCoffeeLintLinter.php

@@ -47,10 +47,6 @@ final class ArcanistCoffeeLintLinter extends ArcanistExternalLinter {
       'npm install -g coffeelint');
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   public function supportsReadDataFromStdin() {
     return true;
   }

src/lint/linter/ArcanistCppcheckLinter.php

@@ -67,6 +67,10 @@ final class ArcanistCppcheckLinter extends ArcanistExternalLinter {
       array('-j2', '--enable=performance,style,portability,information'));
   }
 
+  public function shouldExpectCommandErrors() {
+    return false;
+  }
+
   protected function parseLinterOutput($path, $err, $stdout, $stderr) {
     $dom = new DOMDocument();
     $ok = @$dom->loadXML($stderr);

src/lint/linter/ArcanistCpplintLinter.php

@@ -29,10 +29,6 @@ final class ArcanistCpplintLinter extends ArcanistExternalLinter {
       'googlecode.com/svn/trunk/cpplint/cpplint.py`.');
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   public function supportsReadDataFromStdin() {
     return true;
   }

src/lint/linter/ArcanistExternalLinter.php

@@ -56,7 +56,7 @@ abstract class ArcanistExternalLinter extends ArcanistFutureLinter {
    * @task bin
    */
   public function shouldExpectCommandErrors() {
-    return false;
+    return true;
   }
 
   /**

src/lint/linter/ArcanistFlake8Linter.php

@@ -58,10 +58,6 @@ final class ArcanistFlake8Linter extends ArcanistExternalLinter {
     return pht('Install flake8 using `easy_install flake8`.');
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   protected function parseLinterOutput($path, $err, $stdout, $stderr) {
     $lines = phutil_split_lines($stdout, false);
 

src/lint/linter/ArcanistGoLintLinter.php

@@ -30,6 +30,10 @@ final class ArcanistGoLintLinter extends ArcanistExternalLinter {
     return pht('Install Golint using `go get github.com/golang/lint/golint`.');
   }
 
+  public function shouldExpectCommandErrors() {
+    return false;
+  }
+
   protected function canCustomizeLintSeverities() {
     return true;
   }

src/lint/linter/ArcanistHLintLinter.php

@@ -41,10 +41,6 @@ final class ArcanistHLintLinter extends ArcanistExternalLinter {
     return '-';
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   protected function getMandatoryFlags() {
     return array('--json');
   }

src/lint/linter/ArcanistJSHintLinter.php

@@ -73,10 +73,6 @@ final class ArcanistJSHintLinter extends ArcanistExternalLinter {
     return pht('Install JSHint using `npm install -g jshint`.');
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   public function supportsReadDataFromStdin() {
     return true;
   }

src/lint/linter/ArcanistJSONLintLinter.php

@@ -47,10 +47,6 @@ final class ArcanistJSONLintLinter extends ArcanistExternalLinter {
     return pht('Install jsonlint using `npm install -g jsonlint`.');
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   public function supportsReadDataFromStdin() {
     return true;
   }

src/lint/linter/ArcanistJscsLinter.php

@@ -45,10 +45,6 @@ final class ArcanistJscsLinter extends ArcanistExternalLinter {
     return pht('Install JSCS using `npm install -g jscs`.');
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   protected function getMandatoryFlags() {
     $options = array();
 

src/lint/linter/ArcanistLesscLinter.php

@@ -101,10 +101,6 @@ final class ArcanistLesscLinter extends ArcanistExternalLinter {
     return pht('Install lessc using `npm install -g less`.');
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   public function supportsReadDataFromStdin() {
     // Technically `lessc` can read data from standard input however, when doing
     // so, relative imports cannot be resolved. Therefore, this functionality is

src/lint/linter/ArcanistPEP8Linter.php

@@ -70,10 +70,6 @@ final class ArcanistPEP8Linter extends ArcanistExternalLinter {
     return pht('Install PEP8 using `easy_install pep8`.');
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   protected function parseLinterOutput($path, $err, $stdout, $stderr) {
     $lines = phutil_split_lines($stdout, false);
 

src/lint/linter/ArcanistPhpLinter.php

@@ -55,10 +55,6 @@ final class ArcanistPhpLinter extends ArcanistExternalLinter {
     return $stdout;
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   public function supportsReadDataFromStdin() {
     return false;
   }

src/lint/linter/ArcanistPhpcsLinter.php

@@ -68,10 +68,6 @@ final class ArcanistPhpcsLinter extends ArcanistExternalLinter {
     }
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   public function supportsReadDataFromStdin() {
     return true;
   }

src/lint/linter/ArcanistPuppetLintLinter.php

@@ -52,10 +52,6 @@ final class ArcanistPuppetLintLinter extends ArcanistExternalLinter {
       'gem install puppet-lint');
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   protected function getMandatoryFlags() {
     return array(
       '--error-level=all',

src/lint/linter/ArcanistPyFlakesLinter.php

@@ -53,10 +53,6 @@ final class ArcanistPyFlakesLinter extends ArcanistExternalLinter {
     return pht('Install pyflakes with `pip install pyflakes`.');
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   public function supportsReadDataFromStdin() {
     return true;
   }

src/lint/linter/ArcanistRubyLinter.php

@@ -54,10 +54,6 @@ final class ArcanistRubyLinter extends ArcanistExternalLinter {
     return true;
   }
 
-  public function shouldExpectCommandErrors() {
-    return true;
-  }
-
   protected function getMandatoryFlags() {
     // -w: turn on warnings
     // -c: check syntax