revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00
Code Issues Releases Wiki Activity

Allow ArcanistPhutilLibraryLinter to run with an out-of-date XHPAST binary

Browse source 
Summary: There is no need to check if the XHPAST binary is available here because this linter does not actually parse PHP, it only considers the library map.

Test Plan: Removed the XHPAST binary and ran `arc lint` on a bunch of files.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11528
This commit is contained in:
Joshua Spence 2015-02-03 08:01:11 +11:00
parent 70f9b5d3ae
commit 24ab7b7f38
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/lint/linter/ArcanistPhutilLibraryLinter.php
View file

@ -51,10 +51,6 @@ final class ArcanistPhutilLibraryLinter extends ArcanistLinter {
} }
public function willLintPaths(array $paths) { public function willLintPaths(array $paths) {
if (!xhpast_is_available()) {
throw new Exception(xhpast_get_build_instructions());
}
// NOTE: For now, we completely ignore paths and just lint every library in // NOTE: For now, we completely ignore paths and just lint every library in
// its entirety. This is simpler and relatively fast because we don't do any // its entirety. This is simpler and relatively fast because we don't do any
// detailed checks and all the data we need for this comes out of module // detailed checks and all the data we need for this comes out of module