revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-09-19 16:38:51 +02:00
Code Issues Releases Wiki Activity

Exit with an error code if the workflow returned one.

Browse source 
Summary:
PHP thinks this thing is an integer... and also thinks it's not an
integer... I'm so confused... Anyway, this seems to persuade it to
use the correct overload.

Test Plan:
Ran arc patch with the incant provided in the bug report. It
successfully returned 1, where it didn't before. I didn't test the
perflab stuff; hopefully that aborts when it detects nonzero return.

Reviewers: nh

Reviewed By: nh

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2743
This commit is contained in:
Alan Huang 2012-06-13 16:01:29 -07:00
parent 5089cd7de1
commit 3f4f8992fb
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
scripts/arcanist.php
View file

@ -288,7 +288,7 @@ try {
$workflow->willRunWorkflow(); $workflow->willRunWorkflow();
$err = $workflow->run(); $err = $workflow->run();
$config->didRunWorkflow($command, $workflow, $err); $config->didRunWorkflow($command, $workflow, $err);
exit($err); exit((int)$err);
} catch (ArcanistUsageException $ex) { } catch (ArcanistUsageException $ex) {
echo phutil_console_format( echo phutil_console_format(