revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

Improve the "inline HTML" linter rule

Browse source 
Summary: Improve `ArcanistInlineHTMLXHPASTLinterRule` such that it doesn't raise duplicate warnings. Also be a bit more lax with whitespace.

Test Plan: Unit tests now pass.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D13896
This commit is contained in:
Joshua Spence 2015-08-19 15:34:43 +10:00 committed by Joshua Spence
parent fe8ed2a6f8
commit 4404e66735
3 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/lint/linter/ArcanistInlineHTMLXHPASTLinterRule.php
View file

@ -22,9 +22,14 @@ final class ArcanistInlineHTMLXHPASTLinterRule
continue; continue;
} }
if (preg_match('/^\s*$/', $html->getValue())) {
continue;
}
$this->raiseLintAtToken( $this->raiseLintAtToken(
$html, $html,
pht('PHP files must only contain PHP code.')); pht('PHP files must only contain PHP code.'));
break;
} }
} }

1
src/lint/linter/__tests__/xhpast/embedded-tags.lint-test
View file

@ -2,3 +2,4 @@
This shouldn't fatal the parser. This shouldn't fatal the parser.
~~~~~~~~~~ ~~~~~~~~~~
disabled:2:1

1
src/lint/linter/__tests__/xhpast/php-tags-bad.lint-test
View file

@ -3,6 +3,7 @@ garbage garbage
?> ?>
~~~~~~~~~~ ~~~~~~~~~~
disabled:1:1
error:1:1 error:1:1
~~~~~~~~~~ ~~~~~~~~~~
garbage garbage garbage garbage