revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 08:42:40 +01:00
Code Issues Releases Wiki Activity

Remove "--allow-empty-message"

Browse source 
Summary: @alex has git 1.7.0.4 which doesn't have this flag. We don't actually need it: we always provide a commit message when calling this method. Remove the flag for compatibility, leaving a note in case we bump into this in the future.

Test Plan: N/A

Reviewers: btrahan, vrana, alex

Reviewed By: alex

CC: aran

Differential Revision: https://secure.phabricator.com/D5926
This commit is contained in:
epriestley 2013-05-14 13:35:42 -07:00
parent 3116d3656a
commit 592172c775
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/repository/api/ArcanistGitAPI.php
View file

@ -531,8 +531,12 @@ final class ArcanistGitAPI extends ArcanistRepositoryAPI {
public function doCommit($message) { public function doCommit($message) {
$tmp_file = new TempFile(); $tmp_file = new TempFile();
Filesystem::writeFile($tmp_file, $message); Filesystem::writeFile($tmp_file, $message);
// NOTE: "--allow-empty-message" was introduced some time after 1.7.0.4,
// so we do not provide it and thus require a message.
$this->execxLocal( $this->execxLocal(
'commit --allow-empty-message -F %s', 'commit -F %s',
$tmp_file); $tmp_file);
$this->reloadWorkingCopy(); $this->reloadWorkingCopy();