revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 08:42:40 +01:00
Code Issues Releases Wiki Activity

fix issue where multi-line dataproviders in phpunit were parsed incorrectly when displaying results

Browse source 
Summary: Found an issue where if arc unit runs phpunit and the datasets included a dataprovider which spanned multiple lines, it wasn't filtered out correctly in the result parser, this fixes it

Test Plan: accidentally ran tests against phpunit itself which exhibits this problem. no longer a problem after this fix, nothing else breaks.

Reviewers: epriestley

Reviewed By: epriestley

CC: aurelijus, epriestley, aran

Differential Revision: https://secure.phabricator.com/D6773
This commit is contained in:
Firehed 2013-08-20 06:58:02 -07:00 committed by epriestley
parent 8465c4dd53
commit 5eb82c8e7d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/unit/engine/PhpunitResultParser.php
View file

@ -62,7 +62,7 @@ final class PhpunitResultParser extends ArcanistBaseTestResultParser {
}
}
$name = preg_replace('/ \(.*\)/', '', $event->test);
$name = preg_replace('/ \(.*\)/s', '', $event->test);
$result = new ArcanistUnitTestResult();
$result->setName($name);