revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00
Code Issues Releases Wiki Activity

Use hgsprintf() when managing bookmarks in arc patch in mercurial

Browse source 
Summary: Fixes T4596. I couldn't immediately reproduce this, but the `hgsprintf()` version is clearly more correct.

Test Plan: Used `arc patch --trace` to examine hg commands.

Reviewers: btrahan, durham

Reviewed By: durham

Subscribers: aran, epriestley

Maniphest Tasks: T4596

Differential Revision: https://secure.phabricator.com/D8512
This commit is contained in:
epriestley 2014-03-12 19:43:48 -07:00
parent ac82dea3c9
commit 67239a08a5
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/workflow/ArcanistPatchWorkflow.php
View file

@ -320,12 +320,12 @@ EOTEXT
echo "Updating to the revision's base commit\n"; echo "Updating to the revision's base commit\n";
$repository_api->execPassthru( $repository_api->execPassthru(
'update %s', 'update %s',
$base_revision); hgsprintf('%s', $base_revision));
} }
$repository_api->execxLocal( $repository_api->execxLocal(
'bookmark %s', 'bookmark %s',
$branch_name); hgsprintf('%s', $branch_name));
echo phutil_console_format( echo phutil_console_format(
"Created and checked out bookmark %s.\n", "Created and checked out bookmark %s.\n",