revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-04-05 17:08:24 +02:00
Code Issues Releases Wiki Activity

Fix getting changed files in SVN

Browse source 
Summary:
This is pretty awkward but I don't have anything better.

Also don't compute cache key if caching is disabled.

Test Plan:
  $ svn diff --xml --summarize '' -r 701319:HEAD
  $ svn diff --xml --summarize svn+ssh://tubbs/svnroot/projects/lolbunny -r 701319:HEAD

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4771
This commit is contained in:
vrana 2013-01-31 12:21:26 -08:00
parent 6d521f3b3f
commit 6cd3d8e995
2 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/repository/api/ArcanistSubversionAPI.php
View file

@ -494,10 +494,16 @@ EODIFF;
} }
public function getChangedFiles($since_commit) { public function getChangedFiles($since_commit) {
$url = '';
$match = null;
if (preg_match('/(.*)@(.*)/', $since_commit, $match)) {
list(, $url, $since_commit) = $match;
}
// TODO: Handle paths with newlines. // TODO: Handle paths with newlines.
list($stdout) = $this->execxLocal( list($stdout) = $this->execxLocal(
'--xml diff --revision %s:HEAD --summarize', '--xml diff --revision %s:HEAD --summarize %s',
$since_commit); $since_commit,
$url);
$xml = new SimpleXMLElement($stdout); $xml = new SimpleXMLElement($stdout);
$return = array(); $return = array();

5
src/workflow/ArcanistLintWorkflow.php
View file

@ -195,7 +195,10 @@ EOTEXT
$engine = newv($engine, array()); $engine = newv($engine, array());
$this->engine = $engine; $this->engine = $engine;
$engine->setWorkingCopy($working_copy); $engine->setWorkingCopy($working_copy);
$engine->setRepositoryVersion($this->getRepositoryVersion());
if ($use_cache) {
$engine->setRepositoryVersion($this->getRepositoryVersion());
}
$engine->setMinimumSeverity( $engine->setMinimumSeverity(
$this->getArgument('severity', self::DEFAULT_SEVERITY)); $this->getArgument('severity', self::DEFAULT_SEVERITY));