Fix visibility of various ArcanistLinter methods

Summary: Ref T6822.

Test Plan: Visual inspection. These methods are only called from within the `ArcanistExternalLinter` and `ArcanistLinter` subclasses.

Reviewers: chad, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6822

Differential Revision: https://secure.phabricator.com/D11237

src/lint/linter/ArcanistCSSLintLinter.php

@@ -25,14 +25,14 @@ final class ArcanistCSSLintLinter extends ArcanistExternalLinter {
     return 'csslint';
   }
 
-  public function getMandatoryFlags() {
+  protected function getMandatoryFlags() {
     return array(
       '--format=lint-xml',
       '--quiet',
     );
   }
 
-  public function getDefaultFlags() {
+  protected function getDefaultFlags() {
     return $this->getDeprecatedConfiguration('lint.csslint.options', array());
   }
 

src/lint/linter/ArcanistCSharpLinter.php

@@ -54,7 +54,7 @@ final class ArcanistCSharpLinter extends ArcanistLinter {
     parent::setLinterConfigurationValue($key, $value);
   }
 
-  public function getLintCodeFromLinterConfigurationKey($code) {
+  protected function getLintCodeFromLinterConfigurationKey($code) {
     return $code;
   }
 

src/lint/linter/ArcanistChmodLinter.php

@@ -27,7 +27,7 @@ final class ArcanistChmodLinter extends ArcanistLinter {
     return 'chmod';
   }
 
-  public function shouldLintBinaryFiles() {
+  protected function shouldLintBinaryFiles() {
     return true;
   }
 

src/lint/linter/ArcanistFilenameLinter.php

@@ -25,7 +25,7 @@ final class ArcanistFilenameLinter extends ArcanistLinter {
     return 'filename';
   }
 
-  public function shouldLintBinaryFiles() {
+  protected function shouldLintBinaryFiles() {
     return true;
   }
 
@@ -45,11 +45,11 @@ final class ArcanistFilenameLinter extends ArcanistLinter {
     }
   }
 
-  public function shouldLintDirectories() {
+  protected function shouldLintDirectories() {
     return true;
   }
 
-  public function shouldLintSymbolicLinks() {
+  protected function shouldLintSymbolicLinks() {
     return true;
   }
 

src/lint/linter/ArcanistFlake8Linter.php

@@ -28,7 +28,7 @@ final class ArcanistFlake8Linter extends ArcanistExternalLinter {
     return 'flake8';
   }
 
-  public function getDefaultFlags() {
+  protected function getDefaultFlags() {
     return $this->getDeprecatedConfiguration('lint.flake8.options', array());
   }
 

src/lint/linter/ArcanistHLintLinter.php

@@ -45,7 +45,7 @@ final class ArcanistHLintLinter extends ArcanistExternalLinter {
     return true;
   }
 
-  public function getMandatoryFlags() {
+  protected function getMandatoryFlags() {
     return array('--json');
   }
 

src/lint/linter/ArcanistPEP8Linter.php

@@ -27,7 +27,7 @@ final class ArcanistPEP8Linter extends ArcanistExternalLinter {
     return 'pep8';
   }
 
-  public function getDefaultFlags() {
+  protected function getDefaultFlags() {
     return $this->getDeprecatedConfiguration('lint.pep8.options', array());
   }
 

src/lint/linter/ArcanistPhpLinter.php

@@ -26,7 +26,7 @@ final class ArcanistPhpLinter extends ArcanistExternalLinter {
     return 'php';
   }
 
-  public function getMandatoryFlags() {
+  protected function getMandatoryFlags() {
     return array('-l');
   }
 

src/lint/linter/ArcanistPhpcsLinter.php

@@ -37,7 +37,7 @@ final class ArcanistPhpcsLinter extends ArcanistExternalLinter {
     return pht('Install PHPCS with `pear install PHP_CodeSniffer`.');
   }
 
-  public function getDefaultFlags() {
+  protected function getDefaultFlags() {
     $options = $this->getDeprecatedConfiguration('lint.phpcs.options', array());
     $standard = $this->getDeprecatedConfiguration('lint.phpcs.standard');