revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-24 07:42:39 +01:00
Code Issues Releases Wiki Activity

Declare missing class properties in ArcanistDownloadWorkflow

Browse source 
Summary:
rARCbd9769ba92df63d0429f74ec7fb8b00a4989f28b added and declared the three private properties `$id`, `$saveAs`, `$show`.
However rARC21e80a635d798c5be2c6e5c272497b3170c1e079 removed their declarations while still initializing these properties in `didParseArguments()`.

Test Plan: Run PHPStan static code analysis; grep the code in this class.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25713
This commit is contained in:
Andre Klapper 2024-07-02 21:00:52 +02:00
parent 76d22d70e4
commit 84210cedc6
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/workflow/ArcanistDownloadWorkflow.php
View file

@ -3,6 +3,10 @@
final class ArcanistDownloadWorkflow final class ArcanistDownloadWorkflow
extends ArcanistArcWorkflow { extends ArcanistArcWorkflow {
private $id;
private $saveAs;
private $show;
public function getWorkflowName() { public function getWorkflowName() {
return 'download'; return 'download';
} }