revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 23:02:41 +01:00
Code Issues Releases Wiki Activity

Strip tips out of commit messages from arc backout

Browse source 
Summary:
Fixes T10707. Currently, `arc backout` creates a commit message which includes questionably-helpful "tips" in the message itself.

Strip these out.

Test Plan:
Used `arc backout` to revert any commit, then `git show` to see the generated message.

  - Before patch: included tips.
  - After patch: no tips.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10707

Differential Revision: https://secure.phabricator.com/D15573
This commit is contained in:
epriestley 2016-04-02 06:28:11 -07:00
parent 3d7ac867f5
commit 8701e6c1f3
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/workflow/ArcanistBackoutWorkflow.php
View file

@ -123,6 +123,9 @@ EOTEXT
$template = $this->newInteractiveEditor($template) $template = $this->newInteractiveEditor($template)
->setName('new-commit') ->setName('new-commit')
->editInteractively(); ->editInteractively();
$template = ArcanistCommentRemover::removeComments($template);
return $template; return $template;
} }